Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/ --- (Updated July 9, 2015, 5:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Marco Massenzio
On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: support/post-reviews.py, line 173 https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173 note that here you will be printing the whole commit message, which in this case is not appropriate. I

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/ --- (Updated July 8, 2015, 9:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Michael Park
On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: support/post-reviews.py, line 173 https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173 note that here you will be printing the whole commit message, which in this case is not appropriate. I

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review91048 --- Patch looks great! Reviews applied: [35777] All tests passed. -

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90714 --- Patch looks great! Reviews applied: [35777] All tests passed. -

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-07 Thread Marco Massenzio
On July 7, 2015, 9:42 p.m., Vinod Kone wrote: support/post-reviews.py, line 173 https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173 Why 'format' instead of directly printing the message with a %s? Just curious. It's a more portable way of printing - also,

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90785 --- support/post-reviews.py (line 170)

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-07 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90783 --- Ship it! Minor nit on error message - fix it and commit. Thanks

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-01 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90076 --- support/post-reviews.py (lines 170 - 176)

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-06-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review88957 --- Patch looks great! Reviews applied: [35777] All tests passed. -