Re: Review Request 35838: Added a TODO about RefusedFilter in hierarchical allocator.

2015-06-24 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35838/#review89291
---

Ship it!



src/master/allocator/mesos/hierarchical.hpp (lines 289 - 290)


Hm.. might be helpful for those coming across this if we describe why we 
want to consider separating it. i.e. frameworks might want more revocable 
resources only or non-revocable resources only, but currently the filter only 
expires if there is more of both revocable and non-revocable resources.


- Ben Mahler


On June 24, 2015, 6:17 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35838/
> ---
> 
> (Updated June 24, 2015, 6:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a TODO about RefusedFilter in hierarchical allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> ef18ff850addfb5ce3500ed28e8ffd801e2d24eb 
> 
> Diff: https://reviews.apache.org/r/35838/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 35838: Added a TODO about RefusedFilter in hierarchical allocator.

2015-06-24 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35838/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
---

Added a TODO about RefusedFilter in hierarchical allocator.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
ef18ff850addfb5ce3500ed28e8ffd801e2d24eb 

Diff: https://reviews.apache.org/r/35838/diff/


Testing
---

make check


Thanks,

Jie Yu