Re: Review Request 37192: More basic call validation tests for http api

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review95031
---


Patch looks great!

Reviews applied: [37082, 37192]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2015, 10:58 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 11, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---

(Updated Aug. 11, 2015, 10:58 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Change endpoint names and rebased


Repository: mesos


Description
---

Added more basic call validation tests around malformed body, invalid media 
types etc for the http api


Diffs (updated)
-

  src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf 

Diff: https://reviews.apache.org/r/37192/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 37192: More basic call validation tests for http api

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review95004
---


Patch looks great!

Reviews applied: [37082, 37192]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2015, 8:12 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 11, 2015, 8:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---

(Updated Aug. 11, 2015, 8:12 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Rebased


Repository: mesos


Description
---

Added more basic call validation tests around malformed body, invalid media 
types etc for the http api


Diffs (updated)
-

  src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 

Diff: https://reviews.apache.org/r/37192/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 37192: More basic call validation tests for http api

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94952
---


Patch looks great!

Reviews applied: [37082, 37192]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2015, 5:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 11, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94946
---

Ship it!


Ship It!

- Vinod Kone


On Aug. 11, 2015, 5:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 11, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---

(Updated Aug. 11, 2015, 5:04 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Rebased


Repository: mesos


Description
---

Added more basic call validation tests around malformed body, invalid media 
types etc for the http api


Diffs (updated)
-

  src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 

Diff: https://reviews.apache.org/r/37192/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 37192: More basic call validation tests for http api

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94497
---


Patch looks great!

Reviews applied: [37080, 36720, 37082, 37192]

All tests passed.

- Mesos ReviewBot


On Aug. 7, 2015, 3:05 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 7, 2015, 3:05 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---

(Updated Aug. 7, 2015, 3:05 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Repository: mesos


Description
---

Added more basic call validation tests around malformed body, invalid media 
types etc for the http api


Diffs (updated)
-

  src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 

Diff: https://reviews.apache.org/r/37192/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 37192: More basic call validation tests for http api

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94432
---

Ship it!



src/tests/http_api_tests.cpp (line 137)


s/though//

s/server/master/



src/tests/http_api_tests.cpp (line 145)


s/strings/string/ ?



src/tests/http_api_tests.cpp (line 161)


s/server/master/



src/tests/http_api_tests.cpp (line 199)


did you need to pull this into a temp variable? why not just use it 
directly in #202?


- Vinod Kone


On Aug. 6, 2015, 5:06 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 6, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37192: More basic call validation tests for http api

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94427
---


Patch looks great!

Reviews applied: [37080, 36720, 37082, 37192]

All tests passed.

- Mesos ReviewBot


On Aug. 6, 2015, 5:06 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37192/
> ---
> 
> (Updated Aug. 6, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more basic call validation tests around malformed body, invalid media 
> types etc for the http api
> 
> 
> Diffs
> -
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 37192: More basic call validation tests for http api

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
---

Added more basic call validation tests around malformed body, invalid media 
types etc for the http api


Diffs
-

  src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 

Diff: https://reviews.apache.org/r/37192/diff/


Testing
---

make check


Thanks,

Anand Mazumdar