Re: Review Request 37198: Add Docker image provisioner and copy backend.

> On Sept. 7, 2015, 3:48 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioner.cpp, line 45 > > > > > > This should fit into 80 chars without a linebreak. Also no longer valid :) - Timothy

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review97938 --- src/slave/containerizer/provisioners/docker.hpp (lines 19 - 20)

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review97908 --- I did not realize that we had a combined RR for this chain - please

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 27, 2015, 11:40 p.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 27, 2015, 9:51 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review96523 --- src/Makefile.am (lines 747 - 748)

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 8:58 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 6:48 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 1:32 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

> On Aug. 19, 2015, 6:21 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker.hpp, line 81 > > > > > > Did we introduce DockerImageName later? > > A pair of strings is pretty confusing, how ab

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 19, 2015, 6:42 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review95831 --- src/slave/containerizer/provisioners/docker.hpp (line 81)

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 16, 2015, 8:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 15, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 11, 2015, 11:23 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 10, 2015, 10:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 8, 2015, 1:31 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94584 --- Could you consider my comment on MESOS-2968 w.r.t the Backend API:

Re: Review Request 37198: Add Docker image provisioner and copy backend.

> On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 81 > > > > > > Is this going to be the same with appc? Should we just have one config? Changed to /tmp/mesos/containers/docker, to match

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94485 --- Ship it! LGTM - Guangya Liu On 八月 6, 2015, 8:37 p.m., Lily Chen

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94475 --- src/slave/containerizer/provisioners/docker.hpp (line 81)

Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.