Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-12 Thread Vinod Kone
On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote: src/master/master.hpp, line 1288 https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1288 ? oops. fixed. On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote: src/master/master.hpp, line 1290

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/#review94843 --- Looks pretty good, just some minor things. src/master/master.hpp

Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/#review94695 --- Bad patch! Reviews applied: [37277] Failed command: