Re: Review Request 37495: Docker provisioner local store unit tests.

2015-09-07 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/#review97921
---



src/tests/containerizer/docker_provisioner_tests.cpp (line 66)


s/docker Image/Docker image/


- Till Toenshoff


On Aug. 27, 2015, 11:42 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37495/
> ---
> 
> (Updated Aug. 27, 2015, 11:42 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker provisioner local store unit tests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37495/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-27 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 27, 2015, 11:42 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-27 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 27, 2015, 9:54 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Addressed comments.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-26 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/#review96552
---


This particular RR review is very much on style only -- would like to invest a 
bit more time in the second round for fully grasping the flow of your tests.


src/Makefile.am (line 1698)


Alphabetize please.



src/tests/containerizer/docker_provisioner_tests.cpp (line 135)


Could you please add a one/two-liner above each test that describes its 
purpose?

Imagine an advanced user or developer that tries to run these tests which 
for some reason fail for him - wouldnt it be great if she/he/it immediately 
understood what was being tested without reversing the code?


- Till Toenshoff


On Aug. 25, 2015, 9:01 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37495/
> ---
> 
> (Updated Aug. 25, 2015, 9:01 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker provisioner local store unit tests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37495/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
> --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-25 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 25, 2015, 9:01 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-25 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 25, 2015, 6:49 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-24 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 25, 2015, 1:34 a.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-19 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 19, 2015, 6:45 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, and 
Jiang Yan Xu.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-16 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 16, 2015, 8:36 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs (updated)
-

  src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Re: Review Request 37495: Docker provisioner local store unit tests.

2015-08-14 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

(Updated Aug. 15, 2015, 12:55 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs
-

  src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen

Review Request 37495: Docker provisioner local store unit tests.

2015-08-14 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---

Review request for mesos.


Repository: mesos


Description
---

Docker provisioner local store unit tests.


Diffs
-

  src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 
  src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37495/diff/


Testing
---

sudo make check
./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 
--gtest_shuffle=1


Thanks,

Lily Chen