Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-03 Thread Jiang Yan Xu
> On Sept. 2, 2015, 5:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/appc/store.cpp, line 235 > > > > > > The wording sounds wierd, how about: > > > > "Cannot match any image in store

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-03 Thread Jiang Yan Xu
> On Aug. 31, 2015, 2:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-03 Thread Chi Zhang
> On Aug. 31, 2015, 9:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/#review97585 --- Ship it! Ship It!

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-31 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/#review97157 --- src/slave/containerizer/provisioners/appc/store.hpp (lines 56 -

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-31 Thread Jiang Yan Xu
> On Aug. 31, 2015, 2:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/ --- (Updated Aug. 29, 2015, 9:25 p.m.) Review request for mesos, Jie Yu and

Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos