Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-11-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review105139 --- Ship it! Ship It! - Kapil Arya On Sept. 23, 2015, 9:55 p.m., Ji

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review100354 --- Patch looks great! Reviews applied: [38454] All tests passed. -

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-23 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 24, 2015, 1:55 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-23 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 24, 2015, 1:52 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work? >

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 18, 2015, 2:51 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work? >

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work? >

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99400 --- Thanks for fixing this, but I'm wondering how this fixes the issue.

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99369 --- Patch looks great! Reviews applied: [38454] All tests passed. - M

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 17, 2015, 9:55 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
> On Sept. 17, 2015, 8:48 a.m., haosdent huang wrote: > > Could you use > > > > ``` > > sudo ./mesos-tests.sh > > --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" > > --gtest_repeat=1000 --gtest_break_on_failure > > ``` > > > > to test it? Done, thanks for reminding! - J

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99365 --- Ship it! Ship It! - Guangya Liu On Sept. 17, 2015, 8:28 a.m., Ji

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99361 --- Ship it! Could you use ``` sudo ./mesos-tests.sh --gtest_filter=

Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone. Bugs