Re: Review Request 38814: add test cases for sha512 digest verifier

2015-10-02 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/
---

(Updated Oct. 2, 2015, 11:29 a.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Repository: mesos


Description
---

add test cases for sha512 digest verifier


Diffs (updated)
-

  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38814/diff/


Testing
---

make check (ubuntu 14.04)


Thanks,

Gilbert Song

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-10-02 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/#review101361
---



3rdparty/libprocess/src/tests/digest_tests.cpp (line 130)


You might have to take care of the else case also.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 158)


You will have to guard the call to "digest" with 
DigestTypeTraits::is_implemented.


- Jojy Varghese


On Oct. 2, 2015, 6:29 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38814/
> ---
> 
> (Updated Oct. 2, 2015, 6:29 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> add test cases for sha512 digest verifier
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38814/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/
---

Review request for mesos, Jojy Varghese and Timothy Chen.


Repository: mesos


Description
---

add test cases for sha512 digest verifier


Diffs
-

  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38814/diff/


Testing
---

make check (ubuntu 14.04)


Thanks,

Gilbert Song

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/#review100859
---


Bad patch!

Reviews applied: [38443]

Failed command: ./support/apply-review.sh -n -r 38443

Error:
 2015-09-28 20:39:14 URL:https://reviews.apache.org/r/38443/diff/raw/ 
[11158/11158] -> "38443.patch" [1]
error: patch failed: 
src/slave/containerizer/provisioner/docker/registry_client.cpp:89
error: src/slave/containerizer/provisioner/docker/registry_client.cpp: patch 
does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 28, 2015, 6:06 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38814/
> ---
> 
> (Updated Sept. 28, 2015, 6:06 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> add test cases for sha512 digest verifier
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38814/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/#review100893
---



3rdparty/libprocess/src/tests/digest_tests.cpp (line 82)


You might have to use the TemporaryDrectoryTest fixture for this test and 
any test related to creating temporary file.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 96)


This was a bug in my test. Please see my latest tests.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 121)


same as above


- Jojy Varghese


On Sept. 28, 2015, 6:06 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38814/
> ---
> 
> (Updated Sept. 28, 2015, 6:06 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> add test cases for sha512 digest verifier
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38814/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>