Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/#review104631 --- Ship it! Ship It! - Ben Mahler On Oct. 14, 2015, 4:06 p.m., Joj

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-14 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 14, 2015, 4:06 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 13, 2015, 7:18 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 9, 2015, 6:37 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 9, 2015, 12:58 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Benjamin Mahler
This patch still depends on https://reviews.apache.org/r/38579/, are you planning to remove the dependency? I can't ship these smaller changes since they depend on the large refactor and your layer id patch: https://reviews.apache.org/r/38443/ On Tue, Oct 6, 2015 at 5:16 PM, Jojy Varghese wrote:

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- (Updated Oct. 7, 2015, 12:16 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Jojy Varghese
> On Oct. 6, 2015, 7:57 p.m., Ben Mahler wrote: > > src/slave/containerizer/provisioner/docker/registry_client.hpp, line 67 > > > > > > Please let's avoid conflating independent changes in these patches, as > > it ma

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/#review101681 --- I would have liked to ship this but it looks like the fsLayers rena

Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39014/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --