Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-30 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/#review104631
---

Ship it!


Ship It!

- Ben Mahler


On Oct. 14, 2015, 4:06 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39014/
> ---
> 
> (Updated Oct. 14, 2015, 4:06 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: renamed ManifestResponse as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 1d3377e7462908246dfac90aa0c56314406529c9 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 471783d88b73b62afacac3d7952ebb5d5f442097 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9c3c45a81be6398722a37911788e347a4e91cce8 
> 
> Diff: https://reviews.apache.org/r/39014/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-14 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 14, 2015, 4:06 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
1d3377e7462908246dfac90aa0c56314406529c9 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9c3c45a81be6398722a37911788e347a4e91cce8 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-13 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 13, 2015, 7:18 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-09 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 9, 2015, 6:37 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-08 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 9, 2015, 12:58 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased after reordering patches.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Benjamin Mahler 
This patch still depends on https://reviews.apache.org/r/38579/, are you
planning to remove the dependency? I can't ship these smaller changes since
they depend on the large refactor and your layer id patch:
https://reviews.apache.org/r/38443/

On Tue, Oct 6, 2015 at 5:16 PM, Jojy Varghese  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39014/
> Review request for mesos and Ben Mahler.
> By Jojy Varghese.
>
> *Updated Oct. 7, 2015, 12:16 a.m.*
> Changes
>
> separating out other changes.
>
> *Repository: * mesos
> Description
>
> RegistryClient refactor: renamed ManifestResponse as per review comments.
>
> Testing
>
> make check.
>
> Diffs (updated)
>
>- src/slave/containerizer/provisioner/docker/registry_client.hpp
>(fdb68b675582f603ffb3e96f31c1c9405e238567)
>- src/slave/containerizer/provisioner/docker/registry_client.cpp
>(4931ae8869a697b1e9d8d4cbc0a871e7cd506285)
>- src/tests/containerizer/provisioner_docker_tests.cpp
>(d895eb9d0723e52cff8b21ef2deeaef1911d019c)
>
> View Diff 
>

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 7, 2015, 12:16 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

separating out other changes.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Jojy Varghese 


> On Oct. 6, 2015, 7:57 p.m., Ben Mahler wrote:
> > src/slave/containerizer/provisioner/docker/registry_client.hpp, line 67
> > 
> >
> > Please let's avoid conflating independent changes in these patches, as 
> > it makes it much easier to go through review when we're doing one thing at 
> > a time.
> > 
> > We should pull out naming cleanup into a seperate patch, it looks like 
> > there is a lot of naming cleanup we need to do on these files outside of 
> > just fsLayers. Also, how about s/fsLayers/layers/?

I would like to keep fsLayers as it reflects the language of manifest.


> On Oct. 6, 2015, 7:57 p.m., Ben Mahler wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 67
> > 
> >
> > Can you do a sweep to remove all of the namespace aliases? If you want 
> > to pull them out of the RegistryClient let's use another patch.

Its already removed in a later patch in the series 
(https://reviews.apache.org/r/38941)


> On Oct. 6, 2015, 7:57 p.m., Ben Mahler wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 429
> > 
> >
> > In general please try to use succict, non-redundant names:
> > 
> > s/manifestResponseFuture/manifest
> > 
> > It's clear here that this is a future from the type and now that we've 
> > removed response from the type we should remove it from the name as well.

The idea was to make it obvious 50 lines down from initialization. I can change 
it and create another patch for replacing all xxxFuture with xxx for variable 
names.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/#review101681
---


On Oct. 5, 2015, 8:57 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39014/
> ---
> 
> (Updated Oct. 5, 2015, 8:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: renamed ManifestResponse as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/39014/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-06 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/#review101681
---


I would have liked to ship this but it looks like the fsLayers rename related 
changes need adjustement. Can you please pull that out into a separate patch 
please?

Let's have this patch focus only on the renaming of ManifestResponse.


src/slave/containerizer/provisioner/docker/registry_client.hpp (line 67)


Please let's avoid conflating independent changes in these patches, as it 
makes it much easier to go through review when we're doing one thing at a time.

We should pull out naming cleanup into a seperate patch, it looks like 
there is a lot of naming cleanup we need to do on these files outside of just 
fsLayers. Also, how about s/fsLayers/layers/?



src/tests/containerizer/provisioner_docker_tests.cpp (line 67)


Can you do a sweep to remove all of the namespace aliases? If you want to 
pull them out of the RegistryClient let's use another patch.



src/tests/containerizer/provisioner_docker_tests.cpp (line 429)


In general please try to use succict, non-redundant names:

s/manifestResponseFuture/manifest

It's clear here that this is a future from the type and now that we've 
removed response from the type we should remove it from the name as well.


- Ben Mahler


On Oct. 5, 2015, 8:57 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39014/
> ---
> 
> (Updated Oct. 5, 2015, 8:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: renamed ManifestResponse as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/39014/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese