Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Nov. 2, 2015, 5:43 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 433 > > > > > > I think there are two problems here to address: > > - --net is not always set to host, and if it's not it's causin

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review104679 --- src/docker/docker.cpp (line 433)

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 19, 2015, 11:22 p.m., Niklas Nielsen wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 504 > > > > > > Mind adding a comment about the test sequence? Why does the 'test > > $LIBPROCES

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103182 --- Ship it! See comments below :) src/tests/containerizer/docker_co

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103079 --- Ship it! Ship It! - Guangya Liu On 十月 17, 2015, 11:18 p.m., Mic

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103055 --- Ship it! Ship It! - Klaus Ma On Oct. 17, 2015, 11:18 p.m., Mich

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/containe

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103050 --- src/docker/docker.cpp (line 430)

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103045 --- Patch looks great! Reviews applied: [39388] All tests passed. -

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/ --- (Updated Oct. 17, 2015, 11:18 p.m.) Review request for mesos and Niklas Nielsen

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 16, 2015, 11:18 a.m., Niklas Nielsen wrote: > > Also, let's get a test wired up to verify that this works :) - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review10

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review102956 --- src/docker/docker.cpp (line 427)

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review102915 --- Patch looks great! Reviews applied: [39388] All tests passed. -

Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-3740 https://issue