Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

(Updated Nov. 6, 2015, 6:08 p.m.)


Review request for mesos and Adam B.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

(Updated Nov. 6, 2015, 6:04 p.m.)


Review request for mesos and Adam B.


Changes
---

Address Adam's comments.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway

Re: Review Request 39886: Added documentation about roles.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105393
---

Ship it!


Remove the unrelated configuration.md changes and I'll commit this.


docs/configuration.md (line 50)


If you're changing the flag descriptions in configuration.md, you should 
also be changing the command-line --help strings in the flags.cpp's.

Please remove these unrelated changes for now. We can address them in a 
separate patch along with their command-line --help's.



docs/home.md (line 19)


If we're not doing alphabetical, I would either put this under 
Configuration, under "Attributes and Resources", or just before Reservation.



docs/roles.md (line 79)


More accurately: "... will be allocated twice the fair share of a role with 
a weight of 1."
We cannot guarantee the exact offer ratio, depending on fair-share usage, 
available resources, reservations, filters, etc.


- Adam B


On Nov. 5, 2015, 9:42 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 5, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105365
---

Ship it!


Thanks Neil for the update!

- Guangya Liu


On 十一月 5, 2015, 5:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated 十一月 5, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105295
---


Patch looks great!

Reviews applied: [39886]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 5:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 5, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

(Updated Nov. 5, 2015, 5:42 p.m.)


Review request for mesos and Adam B.


Changes
---

Address comments.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway

Re: Review Request 39886: Added documentation about roles.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105221
---



docs/roles.md (line 60)


s/at/from?



docs/roles.md (line 75)


s/resource. Then/resource, then



docs/roles.md (lines 79 - 80)


s/assigning _weights_ to different roles/assigning different _weights_ to 
roles


- Guangya Liu


On 十一月 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated 十一月 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104977
---


Patch looks great!

Reviews applied: [39886]

All tests passed.

- Mesos ReviewBot


On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

(Updated Nov. 3, 2015, 7:51 p.m.)


Review request for mesos and Adam B.


Changes
---

Various improvements, per review comments.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

> On Nov. 3, 2015, 2:40 a.m., Guangya Liu wrote:
> > docs/attributes-resources.md, line 49
> > 
> >
> > MESOS-3177 is planning to enable adding role dynamically, we may need 
> > to add a TODO here to reflect this.

My preference is to leave this as-is: if/when dynamic roles are added, we can 
update the docs at that point.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104849
---


On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 12
> > 
> >
> > Do you want to be consistent with the existing codebase and continue 
> > use "slave" for now?

We already use "agent" in various places right now (in both code and docs), so 
I think this is okay as-is.


> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 22
> > 
> >
> > Shall we leave a note here that our intention is to add dynamic roles 
> > ASAP?

Not sure this is that important for user-focused docs. When we add dynamic 
roles, we can update the docs.


> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 10
> > 
> >
> > Roles also introduce one level in the hierarchy of resource allocation. 
> > Also putting a framework into a role is the only way to leverage some sort 
> > of prioritization (role weights). Similar to what you say at the bottom of 
> > the doc, I would say it makes sense to mention it here as a use case as 
> > well.

Good point! Done.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104884
---


On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104893
---


Great start. I agree with AlexR that the hierarchical DRF use of roles is 
important enough to mention at the beginning alongside reservations.


docs/roles.md (lines 31 - 32)


As an administrator, you can set `--acls` to declare which framework 
principals can register as which roles.



docs/roles.md (lines 52 - 53)


Unless the slave is started with `--default_role="foo"`, in which case all 
resources on that slave are initially reserved for the `foo` role.



docs/roles.md (line 56)


Also note that you cannot create a persistent volume on unreserved 
resources (those with the `*` role). You must first reserve the disk resource 
and then create the volume.



docs/roles.md (line 61)


I would call this out at the beginning too, since reservations and the 
hierarchical allocation strategy are the two primary functions of roles in 
Mesos (assuming the default allocator).



docs/roles.md (lines 64 - 65)


Also worth mentioning `--weights` here since that affects the current/fair 
share calculation.


- Adam B


On Nov. 2, 2015, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 2, 2015, 5:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104884
---



docs/roles.md (line 10)


Roles also introduce one level in the hierarchy of resource allocation. 
Also putting a framework into a role is the only way to leverage some sort of 
prioritization (role weights). Similar to what you say at the bottom of the 
doc, I would say it makes sense to mention it here as a use case as well.



docs/roles.md (line 12)


Do you want to be consistent with the existing codebase and continue use 
"slave" for now?



docs/roles.md (line 22)


Shall we leave a note here that our intention is to add dynamic roles ASAP?


- Alexander Rukletsov


On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 1:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104868
---


Patch looks great!

Reviews applied: [39886]

All tests passed.

- Mesos ReviewBot


On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 1:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104849
---



docs/attributes-resources.md (line 49)


MESOS-3177 is planning to enable adding role dynamically, we may need to 
add a TODO here to reflect this.


- Guangya Liu


On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 1:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104847
---


Lots more we could discuss: ACLs, more details on DRF, etc. -- but this is a 
start.

- Neil Conway


On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 3, 2015, 1:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

Review request for mesos and Adam B.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway