Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-12-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review108492 --- Ship it! Ship It! - Michael Park On Nov. 30, 2015, 8:33 p.m., G

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 30, 2015, 8:33 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 16, 2015, 11:47 p.m.) Review request for mesos, Adam B, Jie Yu, M

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 13, 2015, 11:12 p.m.) Review request for mesos, Adam B, Jie Yu, M

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review106512 --- Ship it! Ship It! - Jie Yu On Nov. 13, 2015, 4:46 a.m., Greg Ma

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 13, 2015, 4:46 a.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 13, 2015, 4:27 a.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu, Mic

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 9, 2015, 6:09 a.m.) Review request for mesos, Adam B, Jie Yu, Mic

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review105597 --- src/tests/authorization_tests.cpp (line 473)

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 7:35 a.m., Guangya Liu wrote: > > src/tests/authorization_tests.cpp, lines 426-429 > > > > > > Need a request test for this acl. Good catch, thanks Guangya! > On Nov. 6, 2015, 7:35 a.m., Guangya

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 12:07 a.m., Till Toenshoff wrote: > > src/tests/authorization_tests.cpp, line 411 > > > > > > You already did a great job commenting your tests but could you also > > please add 1-2 lines of comme

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 6, 2015, 11:53 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review105378 --- src/tests/authorization_tests.cpp (lines 426 - 429)

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review105323 --- Ship it! src/tests/authorization_tests.cpp (line 411)

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 5, 2015, 9:52 p.m.) Review request for mesos, Adam B, Jie Yu, Mic

Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff. Bug