Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-26 Thread Alexander Rukletsov
> On Nov. 25, 2015, 11:35 p.m., Joris Van Remoortere wrote: > > Added > > ``` > > EXPECT_CALL(sched2, resourceOffers(, _)) > > .Times(0); > > EXPECT_CALL(sched3, resourceOffers(, _)) > > .Times(0); > > ``` > > to resolve The assertion issue opened. > > > > Tested with gtest_shuffle, repeat

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review108074 --- Ship it! Added ``` EXPECT_CALL(sched2, resourceOffers(, _))

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-24 Thread Alexander Rukletsov
> On Nov. 23, 2015, 4:09 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 542 > > > > > > Add ASSERT here to make sure no offers? Could you please elaborate what exactly do you propose? -

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- (Updated Nov. 24, 2015, 4:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- (Updated Nov. 23, 2015, 10:45 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review107546 --- src/tests/master_quota_tests.cpp (line 539)

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- (Updated Nov. 20, 2015, 8:21 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review107310 --- src/tests/master_quota_tests.cpp (line 454)

Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review106940 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,