Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review108151
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 26, 2015, 10:12 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 26, 2015, 10:12 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
>   src/tests/containerizer/isolator_tests.cpp 
> 8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran the CFS tests on 
> Ubuntu 14.04 and CentOS 6.6, and they passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review108145
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 26, 2015, 2:12 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 26, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
>   src/tests/containerizer/isolator_tests.cpp 
> 8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran the CFS tests on 
> Ubuntu 14.04 and CentOS 6.6, and they passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review108139
---


Patch looks great!

Reviews applied: [40679]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 26, 2015, 10:12 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 26, 2015, 10:12 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
>   src/tests/containerizer/isolator_tests.cpp 
> 8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran the CFS tests on 
> Ubuntu 14.04 and CentOS 6.6, and they passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/
---

(Updated Nov. 26, 2015, 10:12 a.m.)


Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, and 
Timothy Chen.


Bugs: MESOS-3964 and MESOS-3978
https://issues.apache.org/jira/browse/MESOS-3964
https://issues.apache.org/jira/browse/MESOS-3978


Repository: mesos


Description
---

Added filtering of CFS cgroup tests.


Diffs
-

  src/tests/containerizer/cgroups_tests.cpp 
2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
  src/tests/containerizer/isolator_tests.cpp 
8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
  src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 

Diff: https://reviews.apache.org/r/40679/diff/


Testing (updated)
---

CFS support is disabled by default and must be enabled via a command-line flag. 
Thus, the test suite should not assume that this feature is present.

To test, run `sudo make check` on Debian 8 or another linux distribution 
without CFS cgroup support.

Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and those 
tests should be filtered out after this patch. I ran the CFS tests on Ubuntu 
14.04 and CentOS 6.6, and they passed.


Thanks,

Greg Mann

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review108110
---

Ship it!


Ship It!

- haosdent huang


On Nov. 26, 2015, 10:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 26, 2015, 10:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
>   src/tests/containerizer/isolator_tests.cpp 
> 8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/
---

(Updated Nov. 26, 2015, 10:06 a.m.)


Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, and 
Timothy Chen.


Changes
---

Addressed comments.


Bugs: MESOS-3964 and MESOS-3978
https://issues.apache.org/jira/browse/MESOS-3964
https://issues.apache.org/jira/browse/MESOS-3978


Repository: mesos


Description
---

Added filtering of CFS cgroup tests.


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
  src/tests/containerizer/isolator_tests.cpp 
8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
  src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 

Diff: https://reviews.apache.org/r/40679/diff/


Testing
---

CFS support is disabled by default and must be enabled via a command-line flag. 
Thus, the test suite should not assume that this feature is present.

To test, run `sudo make check` on Debian 8 or another linux distribution 
without CFS cgroup support.

Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and those 
tests should be filtered out after this patch. I ran `sudo make check` on 
Ubuntu 14.04 and the CFS tests ran like normal, and passed.


Thanks,

Greg Mann

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review108056
---


Patch looks great!

Reviews applied: [40679]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

> On Nov. 25, 2015, 7:06 a.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 147
> > 
> >
> > Cfs should be CFS_ right?

Currently, the tests are not prefixed with `CFS_` the way the CGROUP, etc. 
tests are. I added a todo to change the name of these tests to match that 
convention, and since there are only two of them perhaps I can just take care 
of that in this review.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107933
---


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107933
---



src/tests/environment.cpp (line 147)


Cfs should be CFS_ right?


- Timothy Chen


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

> On Nov. 25, 2015, 1:35 a.m., haosdent huang wrote:
> > src/tests/environment.cpp, line 129
> > 
> >
> > use `/sys/fs/cgroup` maybe have some problems. centos 6 mount cgroup 
> > under `/cgroup` directly. Could refer to how `void 
> > ContainerizerTest::SetUp()` got cgroup 
> > `baseHierarchy`

OK thanks haosdent! I'll look into this.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107892
---


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107892
---



src/tests/environment.cpp (line 129)


use `/sys/fs/cgroup` maybe have some problems. centos 6 mount cgroup under 
`/cgroup` directly. Could refer to how `void 
ContainerizerTest::SetUp()` got cgroup 
`baseHierarchy`


- haosdent huang


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/
---

Review request for mesos, Bernd Mathiske, Marco Massenzio, and Till Toenshoff.


Bugs: MESOS-3964 and MESOS-3978
https://issues.apache.org/jira/browse/MESOS-3964
https://issues.apache.org/jira/browse/MESOS-3978


Repository: mesos


Description
---

Added filtering of CFS cgroup tests.


Diffs
-

  src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 

Diff: https://reviews.apache.org/r/40679/diff/


Testing
---

CFS support is disabled by default and must be enabled via a command-line flag. 
Thus, the test suite should not assume that this feature is present.

To test, run `sudo make check` on Debian 8 or another linux distribution 
without CFS cgroup support.

Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and those 
tests should be filtered out after this patch. I ran `sudo make check` on 
Ubuntu 14.04 and the CFS tests ran like normal, and passed.


Thanks,

Greg Mann