Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110184
---



docs/getting-started.md (line 57)


Not a native speaker, but shouldn't it be `s/If/When` here.

Also, please `s/and rerun/to run/`.


- Benjamin Bannier


On Dec. 11, 2015, 11:20 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> ---
> 
> (Updated Dec. 11, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
> https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110225
---


Patch looks great!

Reviews applied: [41286]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 11, 2015, 11:20 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> ---
> 
> (Updated Dec. 11, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
> https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
---

(Updated Dec. 14, 2015, 4:51 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4118
https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
---

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
---

(Updated Dec. 14, 2015, 4:50 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4118
https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
---

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs (updated)
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues 


> On Dec. 14, 2015, 9:43 a.m., Benjamin Bannier wrote:
> > docs/getting-started.md, line 57
> > 
> >
> > Not a native speaker, but shouldn't it be `s/If/When` here.
> > 
> > Also, please `s/and rerun/to run/`.

I think we could go either way with If/When, but I'll change it. I think we 
want to say 're-run', not just 'run' because we are talking about running it a 
second time after the upgrade.  I agree with saying 'to' instead of 'and' 
though, that's just bad english.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110184
---


On Dec. 14, 2015, 4:51 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> ---
> 
> (Updated Dec. 14, 2015, 4:51 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
> https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>