Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review141531 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review141530 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-01-24 Thread haosdent huang
> On Jan. 24, 2016, 8:21 a.m., Guangya Liu wrote: > > I saw that all of the unit test are using `false` for `local`, can you > > please write some test scenarios in `Testing Done` area? Sure, I test this local before. Add a new unit test would be better. - haosdent -

Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-01-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review116013 --- I saw that all of the unit test are using `false` for `local`, can

Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-01-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review115983 --- Patch looks great! Reviews applied: [41299] Passed command: expo

Re: Review Request 41299: Allow DockerContainerizer log to console.

2016-01-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- (Updated Jan. 23, 2016, 8:58 a.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread haosdent huang
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ > > haosdent huang wrote: > Thank you very much. Should I

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread haosdent huang
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ Thank you very much. Should I discard my patch first? Basical

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 11:28 a.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ > > haosdent huang wrote: > Thank you very much. Should

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110290 --- FYI, I'm making conflicting changes as part of work on a "logging m

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110156 --- Patch looks great! Reviews applied: [41299] Passed command: expor

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- (Updated Dec. 13, 2015, 5:35 a.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110111 --- Ship it! Ship It! src/slave/containerizer/docker.cpp (line 835)

Review Request 41299: Allow DockerContainerizer log to console.

2015-12-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- Review request for mesos, Ben Mahler and Timothy Chen. Bugs: MESOS-4141 htt