Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-03-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review123823 --- include/mesos/resources.hpp (line 174)

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-03-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 三月 15, 2016, 2:33 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 20, 2016, 2:55 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 16, 2016, 4:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review114640 --- Ship it! Nice and simple :) include/mesos/resources.hpp (line

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-14 Thread Guangya Liu
> On 一月 15, 2016, 2:36 a.m., Joseph Wu wrote: > > include/mesos/resources.hpp, line 174 > > > > > > You should briefly define usage slack here. > > > > Suggestion: s/revocable/, revocable resources that are

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 8, 2016, 1:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
> On 一月 6, 2016, 12:01 p.m., Klaus Ma wrote: > > Overall comments is that: is this code called by any others? If not, why > > should we add that? I'd suggest to add this on demand. > > Joseph Wu wrote: > I agree. If this is not used, we should not add it. > > Guangya Liu wrote: > It

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 8, 2016, 6:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review113056 --- src/common/resources.cpp (line 733)

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review113053 --- Overall comments is that: is this code called by any others? If

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-06 Thread Joseph Wu
> On Jan. 6, 2016, 4:01 a.m., Klaus Ma wrote: > > Overall comments is that: is this code called by any others? If not, why > > should we add that? I'd suggest to add this on demand. I agree. If this is not used, we should not add it. - Joseph

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-06 Thread Guangya Liu
> On 一月 6, 2016, 12:01 p.m., Klaus Ma wrote: > > Overall comments is that: is this code called by any others? If not, why > > should we add that? I'd suggest to add this on demand. > > Joseph Wu wrote: > I agree. If this is not used, we should not add it. It is needed as the master need

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 7, 2016, 7:40 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 2, 2016, 1:15 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2015-12-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated Dec. 17, 2015, 9:37 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2015-12-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated Dec. 16, 2015, 2:30 p.m.) Review request for mesos, Artem

Review Request 41333: Added helper functions to filter usage slack resources.

2015-12-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2015-12-13 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review110171 --- src/v1/resources.cpp (line 696)