Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review112257 --- Ship it! Ship It! - Benjamin Hindman On Dec. 22, 2015, 1:35

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review111577 --- Bad patch! Reviews applied: [41002, 41003, 41004, 41061, 4]

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote: > > src/tests/environment.cpp, line 226 > > > > > > If we expect NULL to be a valid option we should make it an Option. > > Joseph Wu wrote: > NULL is not a

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/ --- (Updated Dec. 21, 2015, 5:35 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

> On Dec. 20, 2015, 3:24 p.m., Benjamin Hindman wrote: > > So, are you sure we need `CreateContainerLogger` and not just > > `ContainerLogger::create`? If we're not extending it than I don't know that > > we need it for now. Also, this looks nice and mechanical given > >

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote: > > src/tests/environment.cpp, line 226 > > > > > > If we expect NULL to be a valid option we should make it an Option. NULL is not a valid argument. But for some

Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review110398 --- src/tests/environment.cpp (line 226)