Re: Review Request 41869: Removed Docker auth server flag.

2016-01-04 Thread Timothy Chen
> On Jan. 4, 2016, 5:42 a.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 117 > > > > > > Can we make this ```mutable``` and keep all the methods ```const`

Re: Review Request 41869: Removed Docker auth server flag.

2016-01-04 Thread Timothy Chen
> On Jan. 4, 2016, 6:33 a.m., Jojy Varghese wrote: > > Thanks Tim for taking care of this. I have been thinking that we should > > have TokenManager keep a map of -> . This > > would help us to have any realm being handled by the registry_client + > > token manager. This way, all pull request

Re: Review Request 41869: Removed Docker auth server flag.

2016-01-04 Thread Timothy Chen
> On Jan. 4, 2016, 5:42 a.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, lines > > 293-294 > > > > > > These 2 lines can be combined as: > > > > ``` > >

Re: Review Request 41869: Removed Docker auth server flag.

2016-01-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112502 --- Thanks Tim for taking care of this. I have been thinking that we sh

Re: Review Request 41869: Removed Docker auth server flag.

2016-01-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112496 --- src/slave/containerizer/mesos/provisioner/docker/registry_client.c

Re: Review Request 41869: Removed Docker auth server flag.

2016-01-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/#review112489 --- Patch looks great! Reviews applied: [41868, 41869] Passed command

Review Request 41869: Removed Docker auth server flag.

2016-01-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41869/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository: