Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113536 --- Ship it! Thank you! This is very helpful to the project. We'll get

Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-07 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- (Updated Jan. 7, 2016, 1:55 p.m.) Review request for mesos, Ben Mahler and haos

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113250 --- Bad patch! Reviews applied: [42011] Failed command: ./support/app

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113239 --- Bad patch! Reviews applied: [42011] Failed command: ./support/app

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
> On Jan. 7, 2016, 3:39 a.m., Anand Mazumdar wrote: > > support/docker_build.sh, line 69 > > > > > > Nit: Newline before this line. > > > > Also can you add a comment before this line like we have for other

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- (Updated Jan. 7, 2016, 5:34 a.m.) Review request for mesos, Ben Mahler and haos

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113178 --- Ship it! LGTM. Can you also find a shepherd for this by mailing o

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- (Updated Jan. 7, 2016, 2:44 a.m.) Review request for mesos, Ben Mahler and haos

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113173 --- Ship it! Ship It! - haosdent huang On Jan. 7, 2016, 2:39 a.m.,

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote: > > support/docker_build.sh, line 69 > > > > > > do here overwrite the env `GTEST_FILTER` before? > > haosdent huang wrote: > Seems would overwrite according my

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote: > > support/docker_build.sh, line 69 > > > > > > do here overwrite the env `GTEST_FILTER` before? > > haosdent huang wrote: > Seems would overwrite according my

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- (Updated Jan. 7, 2016, 2:39 a.m.) Review request for mesos and Ben Mahler. Bu

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang
> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote: > > support/docker_build.sh, line 69 > > > > > > do here overwrite the env `GTEST_FILTER` before? Seems would overwrite according my test. - haosdent --

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113167 --- support/docker_build.sh (line 69)

Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4258 https://issues.ap