Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115987 --- Ship it! Ship It! - Jie Yu On Jan. 23, 2016, 10:47 a.m., Jor

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 22, 2016, 5:03 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 314 > > > > > > This is not correct. You've already checked left.disk() == > > right.disk(), why do you need this? Instead, you should

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 23, 2016, 10:47 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 22, 2016, 5:03 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 314 > > > > > > This is not correct. You've already checked left.disk() == > > right.disk(), why do you need this? Instead, you should

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115863 --- src/common/resources.cpp (line 310)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 22, 2016, 9:27 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115648 --- src/common/resources.cpp (lines 102 - 108)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 21, 2016, 7:36 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115324 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2016, 2:29 a.m., Joris V

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 20, 2016, 2:29 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/v1/values.hpp, line 22 > > > > > > Why this change? It was due to a cyclical include between `values.hpp` and `mesos.hpp`; however, since I moved the o

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/type_utils.hpp, line 29 > > > > > > Do you need this? Not after we get rid of `total_size`. I needed it for the scalar comparison. - Joris -

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115260 --- Do we want to expose == and != for DiskInfo::Source yet? We don't e

Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4380 https:/