Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120997 --- Ship it! Ship It! - Michael Park On Feb. 26, 2016, 10:21 p.m

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 10:21 p.m.) Review request for mesos, Michael Park, Nei

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120971 --- Fix it, then Ship it! src/common/resources.cpp (line 68)

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120954 --- Patch looks great! Reviews applied: [42733] Passed command: expo

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 6:31 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 6:30 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review116196 --- Patch looks great! Reviews applied: [42733] Passed command: expo

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Greg Mann
> On Jan. 25, 2016, 9:05 p.m., Neil Conway wrote: > > src/common/resources.cpp, line 66 > > > > > > This is actually correct as written, no? i.e., if principal isn't set, > > `principal()` will return the empty strin

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review116166 --- src/common/resources.cpp (line 66)

Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-01-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- Review request for mesos, Jie Yu, Michael Park, and Neil Conway. Repository: me