Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/
---

(Updated Feb. 4, 2016, 6:40 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address review comment.


Bugs: MESOS-4377
https://issues.apache.org/jira/browse/MESOS-4377


Repository: mesos


Description
---

Note that I also removed an old TODO from `mesos.proto`: it has been partially
implemented, and in general the need for more first-class resource values is
well-known (e.g., many JIRAs on this topic).


Diffs (updated)
-

  docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 

Diff: https://reviews.apache.org/r/43124/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Neil Conway]

> On Feb. 4, 2016, 3:16 p.m., Guangya Liu wrote:
> > docs/attributes-resources.md, lines 94-97
> > 
> >
> > why adjust the order here?

Made it alphabetical.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/#review117818
---


On Feb. 3, 2016, 12:25 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43124/
> ---
> 
> (Updated Feb. 3, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4377
> https://issues.apache.org/jira/browse/MESOS-4377
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that I also removed an old TODO from `mesos.proto`: it has been partially
> implemented, and in general the need for more first-class resource values is
> well-known (e.g., many JIRAs on this topic).
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
> 
> Diff: https://reviews.apache.org/r/43124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/#review117848
---


Fix it, then Ship it!





docs/attributes-resources.md (line 181)


s/at/of/ ?

s/to/of/ ?


- Vinod Kone


On Feb. 3, 2016, 12:25 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43124/
> ---
> 
> (Updated Feb. 3, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4377
> https://issues.apache.org/jira/browse/MESOS-4377
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that I also removed an old TODO from `mesos.proto`: it has been partially
> implemented, and in general the need for more first-class resource values is
> well-known (e.g., many JIRAs on this topic).
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
> 
> Diff: https://reviews.apache.org/r/43124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/#review117818
---




docs/attributes-resources.md (lines 94 - 96)


why adjust the order here?



docs/attributes-resources.md (line 101)


For which case does a slave do not have `cpus` and `mem`? I think that the 
slave should always have values for those two metrics?


- Guangya Liu


On Feb. 3, 2016, 12:25 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43124/
> ---
> 
> (Updated Feb. 3, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4377
> https://issues.apache.org/jira/browse/MESOS-4377
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that I also removed an old TODO from `mesos.proto`: it has been partially
> implemented, and in general the need for more first-class resource values is
> well-known (e.g., many JIRAs on this topic).
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
> 
> Diff: https://reviews.apache.org/r/43124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/#review117565
---



Patch looks great!

Reviews applied: [43124]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 12:25 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43124/
> ---
> 
> (Updated Feb. 3, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4377
> https://issues.apache.org/jira/browse/MESOS-4377
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that I also removed an old TODO from `mesos.proto`: it has been partially
> implemented, and in general the need for more first-class resource values is
> well-known (e.g., many JIRAs on this topic).
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
> 
> Diff: https://reviews.apache.org/r/43124/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43124/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4377
https://issues.apache.org/jira/browse/MESOS-4377


Repository: mesos


Description
---

Note that I also removed an old TODO from `mesos.proto`: it has been partially
implemented, and in general the need for more first-class resource values is
well-known (e.g., many JIRAs on this topic).


Diffs
-

  docs/attributes-resources.md 53a27f48c94baa9b25a072e0fc503bde0b240ba2 
  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 

Diff: https://reviews.apache.org/r/43124/diff/


Testing
---


Thanks,

Neil Conway