Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review117806
---




3rdparty/libprocess/src/process.cpp (line 2202)


blank line before.



3rdparty/libprocess/src/process.cpp (line 2211)


Just `os::getenv("LIB...")` is OK.


- Klaus Ma


On Feb. 4, 2016, 4:57 a.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 4, 2016, 4:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.
> 
> The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
> created, respectively. The last 3 tests generated warnings, e.g., 
> "LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review117775
---



I think that this is a duplicate patch with https://reviews.apache.org/r/43149/

- Guangya Liu


On Feb. 3, 2016, 8:57 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 3, 2016, 8:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.
> 
> The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
> created, respectively. The last 3 tests generated warnings, e.g., 
> "LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review117677
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 3, 2016, 8:57 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 3, 2016, 8:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.
> 
> The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
> created, respectively. The last 3 tests generated warnings, e.g., 
> "LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Review Request 43144: Added env var to set upper bound on number of worker threads.

[Maged Michael]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/
---

Review request for mesos.


Summary (updated)
-

Added env var to set upper bound on number of worker threads.


Repository: mesos


Description (updated)
---

Added env var to set upper bound on number of worker threads.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437 

Diff: https://reviews.apache.org/r/43144/diff/


Testing (updated)
---

Invocations of mesos-master, mesos-slave, and mesos-tests with the 
LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
"-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.

The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
created, respectively. The last 3 tests generated warnings, e.g., 
"LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".


Thanks,

Maged Michael