Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
> On Feb. 12, 2016, 7:05 p.m., Jie Yu wrote: > > we should ignore the comment lines, instead of relax this check > > Cong Wang wrote: > No, the comment is at the end of the "nameserver" line, not separated. oh, ic, got it. - Jie

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119072 --- Ship it! Ship It! - Jie Yu On Feb. 12, 2016, 6:57 p.m.,

Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119065 --- we should ignore the comment lines, instead of relax this check

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Cong Wang
> On Feb. 12, 2016, 7:05 p.m., Jie Yu wrote: > > we should ignore the comment lines, instead of relax this check No, the comment is at the end of the "nameserver" line, not separated. - Cong --- This is an automatically generated

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119073 --- Patch looks great! Reviews applied: [43535] Passed command: