Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119380
---



Open issues were adressed by https://reviews.apache.org/r/43633.

- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119364
---


Fix it, then Ship it!





docs/multiple-disk.md (line 54)


s/multiple-disk/multiple disk
for consistency?



docs/multiple-disk.md (line 80)


What happends if a framework attemps to do so?



docs/multiple-disk.md (line 95)


maybe: the `posix/disk` isolator is disabled?
quota enforcements could be confused with Mesos quota



docs/multiple-disk.md (line 129)


s/for/by ?



docs/persistent-volume.md (line 29)


s/Multiple Disk/multiple disk
consistent capitalization with the above doc.


- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119258
---




docs/multiple-disk.md (line 31)


According to the styleguide we currently use indentation for json code (see 
quota.md).



docs/multiple-disk.md (line 58)


According to the styleguide we currently use indentation for json code (see 
quota.md).


- Joerg Schad


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119363
---




docs/multiple-disk.md (line 138)


This sentence is a bit vague/confusing.


- Neil Conway


On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/
---

(Updated Feb. 16, 2016, 9:43 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description
---

Added documentation for multiple-disk support.


Diffs (updated)
-

  docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
  docs/multiple-disk.md PRE-CREATION 
  docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 

Diff: https://reviews.apache.org/r/43583/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119357
---


Fix it, then Ship it!





docs/multiple-disk.md (line 83)


"write-ahead logs"



docs/multiple-disk.md (line 87)


"mount a physical disk" seems a bit better, since we talk about a single 
mount point later in the sentence.



docs/multiple-disk.md (line 92)


"over-run" => "exceed"



docs/multiple-disk.md (line 93)


"file-system mounted" => "file system in use"



docs/multiple-disk.md (line 125)


I'd say "destroyed" w/o backticks.



docs/multiple-disk.md (line 127)


"destroying"

"strongly encouraged"



docs/multiple-disk.md (line 128)


"do not get penalized" => "are not penalized"


- Neil Conway


On Feb. 16, 2016, 1:58 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119326
---



Patch looks great!

Reviews applied: [43583]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 1:58 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 16, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for multiple-disk support.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/multiple-disk.md PRE-CREATION 
>   docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-16 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/
---

(Updated Feb. 16, 2016, 1:58 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description (updated)
---

Added documentation for multiple-disk support.


Diffs (updated)
-

  docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
  docs/multiple-disk.md PRE-CREATION 
  docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3 

Diff: https://reviews.apache.org/r/43583/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-15 Thread Neil Conway 


> On Feb. 15, 2016, 8:39 p.m., Neil Conway wrote:
> > docs/multiple-disk.md, line 12
> > 
> >
> > "three forms"
> > 
> > Is there a reason to say "currently"? I'd be inclined to remove it as 
> > redundant.
> 
> Joris Van Remoortere wrote:
> The reason I used currently is because we will likely introduce a 4th: 
> block devices. Is there a better way to express this? Maybe it's not 
> important to clarify that just yet?

I'd opt for just documenting the current state without saying "currently"; we 
can then update the docs when a fourth variant is added.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119238
---


On Feb. 15, 2016, 7:42 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 15, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-15 Thread Joris Van Remoortere 


> On Feb. 15, 2016, 8:39 p.m., Neil Conway wrote:
> > docs/multiple-disk.md, line 12
> > 
> >
> > "three forms"
> > 
> > Is there a reason to say "currently"? I'd be inclined to remove it as 
> > redundant.

The reason I used currently is because we will likely introduce a 4th: block 
devices. Is there a better way to express this? Maybe it's not important to 
clarify that just yet?


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119238
---


On Feb. 15, 2016, 7:42 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 15, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119241
---



Patch looks great!

Reviews applied: [43583]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 15, 2016, 7:42 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 15, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43583: Added documentation for multiple-disk support.

2016-02-15 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119238
---



Can we link to this page from `home.md`? Also, we should update 
`persistent-volume.md` to discuss the concepts here briefly, and add a link to 
this page.


docs/multiple-disk.md (line 9)


"understanding" doesn't seem like the best choice of phrase. "by 
examining", perhaps?

maybe "`source` field", not "qualifier"?



docs/multiple-disk.md (line 12)


"three forms"

Is there a reason to say "currently"? I'd be inclined to remove it as 
redundant.



docs/multiple-disk.md (line 22)


"JSON-formatted"



docs/multiple-disk.md (line 79)


"can __not__" => "__cannot__"



docs/multiple-disk.md (line 80)


"in to" => "into"


- Neil Conway


On Feb. 15, 2016, 7:42 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43583/
> ---
> 
> (Updated Feb. 15, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-4531
> https://issues.apache.org/jira/browse/MESOS-4531
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/multiple-disk.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43583: Added documentation for multiple-disk support.

2016-02-15 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/
---

Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-4531
https://issues.apache.org/jira/browse/MESOS-4531


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/multiple-disk.md PRE-CREATION 

Diff: https://reviews.apache.org/r/43583/diff/


Testing
---


Thanks,

Joris Van Remoortere