Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review123167 --- Ship it! - Joris Van Remoortere On March 11, 2016, 9:24

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Alex Clemmer
> On March 11, 2016, 4 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 70-71 > > > > > > What does setting it twice do? It appends `${ZLIB_ROOT}-build` to a list

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/ --- (Updated March 11, 2016, 9:24 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review123086 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines

Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris