Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review121143
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 28, 2016, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 28, 2016, 6:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in \`slave/container_launch_errors\` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via \`Metrics()\` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/
---

(Updated Feb. 28, 2016, 11:27 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Verified the expected change happened.


Bugs: MESOS-4784
https://issues.apache.org/jira/browse/MESOS-4784


Repository: mesos


Description (updated)
---

To observe a changed metric in \`slave/container_launch_errors\` the
triggering action should have taken place. Currently, the test usually
passes, since hitting the metrics endpoint via \`Metrics()\` could block
for longer times due to the endpoint's implicit rate limiting. Once we
disable that blocking with MESOS-4783 this implicit assumption becomes
invalid and the test would be much more likely to fail.


Diffs (updated)
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44063/diff/


Testing
---

make check with unoptimized build OS X both with rate-limiting enabled and 
disabled

With MESOS-4783 applied the test fails before this patch and passes after 
applying it.


Thanks,

Benjamin Bannier

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review121135
---


Fix it, then Ship it!




Simple enough.


src/tests/slave_tests.cpp (line 1161)


Why not verify the failureUpdate is TASK_FAILED?


- Adam B


On Feb. 26, 2016, 10:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 26, 2016, 10:59 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in `slave/container_launch_errors` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via `Metrics()` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review120930
---


Ship it!




We should really add an effort to get this kind of fixes everywhere.

- Alexander Rojas


On Feb. 26, 2016, 7:59 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 26, 2016, 7:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in `slave/container_launch_errors` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via `Metrics()` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review120859
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 26, 2016, 10:06 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 26, 2016, 10:06 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in `slave/container_launch_errors` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via `Metrics()` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 44063: Waited for status update to happen before proceeding in test.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/
---

Review request for mesos.


Bugs: MESOS-4784
https://issues.apache.org/jira/browse/MESOS-4784


Repository: mesos


Description
---

To observe a changed metric in `slave/container_launch_errors` the
triggering action should have taken place. Currently, the test usually
passes, since hitting the metrics endpoint via `Metrics()` could block
for longer times due to the endpoint's implicit rate limiting. Once we
disable that blocking with MESOS-4783 this implicit assumption becomes
invalid and the test would be much more likely to fail.


Diffs
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44063/diff/


Testing
---

make check with unoptimized build OS X both with rate-limiting enabled and 
disabled

With MESOS-4783 applied the test fails before this patch and passes after 
applying it.


Thanks,

Benjamin Bannier