Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-19 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review124394
---


Ship it!




Ship It!

- Joerg Schad


On March 17, 2016, 7:42 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 17, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 12a1fd70a06bb93331c2772b85769c35d0d9bf08 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-19 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review124388
---


Ship it!




Ship It!

- Adam B


On March 17, 2016, 12:42 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 17, 2016, 12:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 12a1fd70a06bb93331c2772b85769c35d0d9bf08 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 17, 2016, 7:42 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.hpp 12a1fd70a06bb93331c2772b85769c35d0d9bf08 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-14 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 14, 2016, 2:33 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-14 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review123398
---



I think you need to remove your `constants.cpp` after Neil's update, and you 
should move your new comment into the hpp now.

- Adam B


On March 13, 2016, 9:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 13, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472 
>   src/master/constants.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-13 Thread Greg Mann 


> On March 13, 2016, 4:26 p.m., Joerg Schad wrote:
> > src/master/constants.hpp, line 136
> > 
> >
> > Should we make it "master HTTP authentication realm."?

Good idea; done!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review123316
---


On March 14, 2016, 4:18 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 14, 2016, 4:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472 
>   src/master/constants.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 14, 2016, 4:18 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472 
  src/master/constants.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review123316
---


Fix it, then Ship it!





src/master/constants.hpp (line 136)


Should we make it "master HTTP authentication realm."?


- Joerg Schad


On March 11, 2016, 10:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 11, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-13 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review123306
---


Ship it!




Ship It!

- Adam B


On March 11, 2016, 2:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 11, 2016, 2:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Greg Mann 


> On March 10, 2016, 4:02 a.m., Alexander Rojas wrote:
> > I just did a grep and I found this:
> > 
> > ```sh
> > $ ag --cpp --ignore="build/.*" '\"mesos\"' .
> > # ...
> > src/authentication/http/basic_authenticator_factory.cpp
> > 66:  Authenticator* authenticator = new BasicAuthenticator("mesos", 
> > credentials);
> > 
> > src/master/constants.hpp
> > 136:// Name of the default, "mesos" HTTP authentication realm.
> > # ...
> > ```
> > 
> > at least those two need to be changed.
> 
> Adam B wrote:
> Hmm, if the first one is used by both master and agent, then we might 
> need to pass the realm as a parameter to the factory's create method.
> Good call with the grep, Alexander.

Thanks for catching this, Alex! I posted a patch which alters the default 
authenticator to accept a realm when it's created: 
https://reviews.apache.org/r/44678/


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
---


On March 10, 2016, 9:40 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 10, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 10, 2016, 9:40 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Adam B 


> On March 9, 2016, 8:02 p.m., Alexander Rojas wrote:
> > I just did a grep and I found this:
> > 
> > ```sh
> > $ ag --cpp --ignore="build/.*" '\"mesos\"' .
> > # ...
> > src/authentication/http/basic_authenticator_factory.cpp
> > 66:  Authenticator* authenticator = new BasicAuthenticator("mesos", 
> > credentials);
> > 
> > src/master/constants.hpp
> > 136:// Name of the default, "mesos" HTTP authentication realm.
> > # ...
> > ```
> > 
> > at least those two need to be changed.

Hmm, if the first one is used by both master and agent, then we might need to 
pass the realm as a parameter to the factory's create method.
Good call with the grep, Alexander.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
---


On March 9, 2016, 12:42 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 9, 2016, 12:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-09 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
---



I just did a grep and I found this:

```sh
$ ag --cpp --ignore="build/.*" '\"mesos\"' .
# ...
src/authentication/http/basic_authenticator_factory.cpp
66:  Authenticator* authenticator = new BasicAuthenticator("mesos", 
credentials);

src/master/constants.hpp
136:// Name of the default, "mesos" HTTP authentication realm.
# ...
```

at least those two need to be changed.

- Alexander Rojas


On March 9, 2016, 9:42 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 9, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 9, 2016, 8:42 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-09 Thread Greg Mann 


> On March 8, 2016, 11:37 p.m., Adam B wrote:
> > src/master/constants.cpp, lines 52-53
> > 
> >
> > Would the same hold true for any machine that runs both a master and an 
> > agent process?
> > Or is it only when master and agent are inside the same linux process?

This is only an issue when master and agent share the same instance of 
libprocess, which is the case in our tests, but is not the case if you run the 
master and agent binaries on a single machine.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122630
---


On March 8, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 8, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122669
---



Patch looks great!

Reviews applied: [44515, 44523]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 8, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 8, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122630
---




src/master/constants.cpp (lines 52 - 53)


Would the same hold true for any machine that runs both a master and an 
agent process?
Or is it only when master and agent are inside the same linux process?


- Adam B


On March 8, 2016, 11:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 8, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs
-

  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann