Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review128503 --- Fix it, then Ship it! Thanks for the tests, I only commented on

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- (Updated April 12, 2016, 4:59 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-11 Thread Zhitao Li
> On April 9, 2016, 12:16 a.m., Ben Mahler wrote: > > Looks pretty good, thanks! > > > > Could you also add tests that mirror the task label tests? > > > > ``` > > $ grep -R TEST src/tests | grep TaskLabels > > src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels) > > src/tests/slave_tests.

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review127918 --- Looks pretty good, thanks! Could you also add tests that mirror t

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-08 Thread Ben Mahler
> On April 4, 2016, 5:26 p.m., haosdent huang wrote: > > CHANGELOG, line 49 > > > > > > Usually we don't need change file. It would be changed by release > > manager. > > Zhitao Li wrote: > hmm, right now the to

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-04 Thread Zhitao Li
> On April 4, 2016, 5:26 p.m., haosdent huang wrote: > > CHANGELOG, line 49 > > > > > > Usually we don't need change file. It would be changed by release > > manager. hmm, right now the top section of CHANGELOG is w

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126862 --- CHANGELOG (line 49)

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review126538 --- Patch looks great! Reviews applied: [45572] Passed command: expo

Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-03-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5029 https://issues.ap