Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129637
---




3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 63)


Shouldn't this be `Try`? Here and below.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 65)


Please use `ASSERT_TRUE` instead.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (lines 66 - 68)


This fits in one line.



3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp (line 83)


We should be looking at `result.error().code`. Here and below.


- Michael Park


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> ---
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129232
---



Bad patch!

Reviews applied: [46293, 46285, 43985, 46010, 46009]

Failed command: ./support/apply-review.sh -n -r 46285

Error:
2016-04-16 01:31:22 URL:https://reviews.apache.org/r/46285/diff/raw/ 
[2127/2127] -> "46285.patch" [1]
error: patch failed: 3rdparty/libprocess/src/poll_socket.cpp:132
error: 3rdparty/libprocess/src/poll_socket.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12557/console

- Mesos ReviewBot


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> ---
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Review Request 46293: Windows: [3/3] Updated `sendfile` test.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [3/3] Updated `sendfile` test.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 

Diff: https://reviews.apache.org/r/46293/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat