Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129565 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 8:21 a.m.,

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129557 --- Patch looks great! Reviews applied: [46331] Passed command:

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129554 --- Fix it, then Ship it! Ship It!

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Qian Zhang
> On April 19, 2016, 8:56 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 119-125 > > > > > > I would suggest that we don't save that in Info. This is because 'Info' > >

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/ --- (Updated April 19, 2016, 4:21 p.m.) Review request for mesos, Avinash

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129459 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Jie Yu
> On April 18, 2016, 7:42 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1439-1453 > > > > > > I think we should bind mount the source to the corresponding

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Qian Zhang
> On April 19, 2016, 3:42 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1439-1453 > > > > > > I think we should bind mount the source to the corresponding

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129346 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129354 --- Patch looks great! Reviews applied: [46331] Passed command:

Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5225