Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46945/
---

(Updated May 4, 2016, 12:30 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and 
Joris Van Remoortere.


Changes
---

`s/elem/v/`


Bugs: MESOS-3214
https://issues.apache.org/jira/browse/MESOS-3214


Repository: mesos


Description (updated)
---

Renamed a shadowing variable.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 

Diff: https://reviews.apache.org/r/46945/diff/


Testing
---

`make check` on Ubuntu 14.04 with GCC 4.8


Thanks,

Michael Park

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46945/#review131581
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 749 - 751)


Could we avoid the 'elem' name in favor of 'element' or 'v' (full word or 
single letter)?

Per our conversation, do we want to adjust the foreachpair above?


- Ben Mahler


On May 3, 2016, 10:54 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46945/
> ---
> 
> (Updated May 3, 2016, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3214
> https://issues.apache.org/jira/browse/MESOS-3214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `value` variable declared in the `foreach` used to shadow the `value`
> function parameter. This seemed to have been ok with the `FOREACH` macro,
> butthis is no longer ok with `range-based for`.
> This seems to be the only place of violation of this.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 
> 
> Diff: https://reviews.apache.org/r/46945/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 14.04 with GCC 4.8
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46945/
---

(Updated May 3, 2016, 10:54 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and 
Joris Van Remoortere.


Bugs: MESOS-3214
https://issues.apache.org/jira/browse/MESOS-3214


Repository: mesos


Description (updated)
---

The `value` variable declared in the `foreach` used to shadow the `value`
function parameter. This seemed to have been ok with the `FOREACH` macro,
butthis is no longer ok with `range-based for`.
This seems to be the only place of violation of this.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 

Diff: https://reviews.apache.org/r/46945/diff/


Testing
---

`make check` on Ubuntu 14.04 with GCC 4.8


Thanks,

Michael Park

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46945/#review131553
---


Ship it!




Ship It!

- Benjamin Bannier


On May 3, 2016, 10:34 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46945/
> ---
> 
> (Updated May 3, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3214
> https://issues.apache.org/jira/browse/MESOS-3214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `value` variable declared in the `foreach` shadows the `value` function 
> parameter. This seemed to have been ok with the `FOREACH` macro, but this is 
> no longer ok with `range-based for`.
> This seems to be the only place of violation of this.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 
> 
> Diff: https://reviews.apache.org/r/46945/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 14.04 with GCC 4.8
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46945/
---

Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and 
Joris Van Remoortere.


Bugs: MESOS-3214
https://issues.apache.org/jira/browse/MESOS-3214


Repository: mesos


Description
---

The `value` variable declared in the `foreach` shadows the `value` function 
parameter. This seemed to have been ok with the `FOREACH` macro, but this is no 
longer ok with `range-based for`.
This seems to be the only place of violation of this.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 

Diff: https://reviews.apache.org/r/46945/diff/


Testing
---

`make check` on Ubuntu 14.04 with GCC 4.8


Thanks,

Michael Park