Re: Review Request 47522: Added creator principal to persistent volume tests.

[Greg Mann]

> On May 27, 2016, 9:47 a.m., Bernd Mathiske wrote:
> > src/tests/persistent_volume_tests.cpp, line 1448
> > 
> >
> > As we have "volume and subsequent statements in a scope block above, 
> > can we have the same here, please?

This instance doesn't turn out quite as elegant as the previous one, since this 
`volume` gets used for the remainder of the test. If we scoped it, the scope 
would need to extend nearly to the end of the test. What do you think?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review135200
---


On May 27, 2016, 6:25 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> ---
> 
> (Updated May 27, 2016, 6:25 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47522: Added creator principal to persistent volume tests.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review135200
---




src/tests/persistent_volume_tests.cpp (line 1448)


As we have "volume and subsequent statements in a scope block above, can we 
have the same here, please?



src/tests/persistent_volume_tests.cpp (line 1665)


Same here: above block around "volume" with braces, this one without.


- Bernd Mathiske


On May 26, 2016, 11:25 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> ---
> 
> (Updated May 26, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47522: Added creator principal to persistent volume tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/
---

(Updated May 27, 2016, 6:25 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch adds a creator principal to the
persistent volumes used in the PersistentVolumeTests.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 

Diff: https://reviews.apache.org/r/47522/diff/


Testing
---

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 47522: Added creator principal to persistent volume tests.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review135095
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 18, 2016, 8:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> ---
> 
> (Updated May 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47522: Added creator principal to persistent volume tests.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review134351
---


Ship it!




Ship It!

- Bernd Mathiske


On May 18, 2016, 1:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> ---
> 
> (Updated May 18, 2016, 1:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 47522: Added creator principal to persistent volume tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch adds a creator principal to the
persistent volumes used in the PersistentVolumeTests.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 

Diff: https://reviews.apache.org/r/47522/diff/


Testing
---

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann