Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review134057 --- Bad patch! Reviews applied: [47585] Failed command: ./support/ap

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133982 --- Ship it! To fix the underlying issue, this is now submitted. Le

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Kevin Klues
> On May 19, 2016, 8:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or just

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Kevin Klues
> On May 19, 2016, 8:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or just

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Jan Schlicht
> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or jus

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Jan Schlicht
> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! > > Benjamin Bannier wrote: > +1, or jus

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Benjamin Bannier
> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > > > > > Let's just wrap this in a `std::unique_ptr` instead! +1, or just a `std::string` since most proba

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133903 --- Since this was easy to pin down could you mention the commit which

Re: Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133900 --- 3rdparty/stout/include/stout/os/read.hpp (line 118)

Review Request 47585: Fixed a mismatched 'delete'.

2016-05-19 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/ --- Review request for mesos, Benjamin Bannier and Bernd Mathiske. Repository: meso