Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-06-07 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/#review136526
---


Ship it!




Fixing the description.

- Joris Van Remoortere


On May 29, 2016, 2:07 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47602/
> ---
> 
> (Updated May 29, 2016, 2:07 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Added Windows support for folder `launcher/`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows.hpp 
> a71e2f4965c982331c2e8fe4be70027b373a6516 
> 
> Diff: https://reviews.apache.org/r/47602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

(Updated May 29, 2016, 2:07 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
a71e2f4965c982331c2e8fe4be70027b373a6516 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

(Updated May 28, 2016, 10:43 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
a71e2f4965c982331c2e8fe4be70027b373a6516 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

(Updated May 28, 2016, 7:01 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
a71e2f4965c982331c2e8fe4be70027b373a6516 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

(Updated May 28, 2016, 2:21 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Changes
---

master rebased


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
a71e2f4965c982331c2e8fe4be70027b373a6516 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-27 Thread Alex Clemmer 


> On May 24, 2016, 11:51 p.m., Joris Van Remoortere wrote:
> > 3rdparty/stout/include/stout/windows.hpp, lines 420-431
> > 
> >
> > Can you provide a little more context for these?
> > I see what you're doing, not sure of why or what it impacts.
> > Thanks!

REGISTERING, REGISTERED as mesos-angent state but are define in NetBios header. 
This code should just undef them, amek the in is not necessary.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/#review134665
---


On May 19, 2016, 4:08 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47602/
> ---
> 
> (Updated May 19, 2016, 4:08 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Added Windows support for folder `launcher/`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows.hpp 
> a7a59e78575e1456b4e14d18ac97f51dd23d794e 
> 
> Diff: https://reviews.apache.org/r/47602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-24 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/#review134665
---




3rdparty/stout/include/stout/windows.hpp (lines 420 - 431)


Can you provide a little more context for these?
I see what you're doing, not sure of why or what it impacts.
Thanks!


- Joris Van Remoortere


On May 19, 2016, 4:08 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47602/
> ---
> 
> (Updated May 19, 2016, 4:08 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Added Windows support for folder `launcher/`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows.hpp 
> a7a59e78575e1456b4e14d18ac97f51dd23d794e 
> 
> Diff: https://reviews.apache.org/r/47602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

2016-05-19 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47602/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout:[1/2] Added Windows support for folder `launcher/`.


Diffs
-

  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 

Diff: https://reviews.apache.org/r/47602/diff/


Testing
---


Thanks,

Alex Clemmer