Re: Review Request 52018: Renamed Hook to ParentHook in Mesos [2/2].

2016-09-21 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/#review149843
---


Ship it!




Ship It!

- Jie Yu


On Sept. 21, 2016, 3:21 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52018/
> ---
> 
> (Updated Sept. 21, 2016, 3:21 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed Hook to ParentHook in Mesos [2/2].
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
>   src/slave/containerizer/mesos/launcher.cpp 
> 73a0e5f50042b1249224a4a42e2442b7ea51dfff 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 1c49f568b12f5ad688bb43625de3dcbfd618ca79 
>   src/tests/containerizer/launcher.hpp 
> f87b3ce92c6a5d996995833d79c976db6afe2700 
> 
> Diff: https://reviews.apache.org/r/52018/diff/
> 
> 
> Testing
> ---
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 52018: Renamed Hook to ParentHook in Mesos [2/2].

2016-09-21 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/
---

(Updated Sept. 21, 2016, 3:21 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Renamed Hook to ParentHook in Mesos [2/2].


Repository: mesos


Description (updated)
---

Renamed Hook to ParentHook in Mesos [2/2].


Diffs (updated)
-

  src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
  src/slave/container_loggers/lib_logrotate.cpp 
1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
  src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
  src/slave/containerizer/mesos/launcher.hpp 
61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
  src/slave/containerizer/mesos/launcher.cpp 
73a0e5f50042b1249224a4a42e2442b7ea51dfff 
  src/slave/containerizer/mesos/linux_launcher.hpp 
dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
  src/slave/containerizer/mesos/linux_launcher.cpp 
1c49f568b12f5ad688bb43625de3dcbfd618ca79 
  src/tests/containerizer/launcher.hpp f87b3ce92c6a5d996995833d79c976db6afe2700 

Diff: https://reviews.apache.org/r/52018/diff/


Testing
---

sudo make check + internal ci


Thanks,

Joerg Schad

Re: Review Request 52018: Renamed Hook to ParentHook in Mesos.

2016-09-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/#review149418
---



Patch looks great!

Reviews applied: [45491, 45492, 52015, 52016, 52017, 52018]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 18, 2016, 7:50 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52018/
> ---
> 
> (Updated Sept. 18, 2016, 7:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed Hook to ParentHook in Mesos.
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
>   src/slave/containerizer/mesos/launcher.cpp 
> 73a0e5f50042b1249224a4a42e2442b7ea51dfff 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 1c49f568b12f5ad688bb43625de3dcbfd618ca79 
>   src/tests/containerizer/launcher.hpp 
> f87b3ce92c6a5d996995833d79c976db6afe2700 
> 
> Diff: https://reviews.apache.org/r/52018/diff/
> 
> 
> Testing
> ---
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 52018: Renamed Hook to ParentHook in Mesos.

2016-09-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/#review149415
---


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp (line 133)


The indent here seems not correct, should be 4 spaces.


- Qian Zhang


On Sept. 19, 2016, 3:50 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52018/
> ---
> 
> (Updated Sept. 19, 2016, 3:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed Hook to ParentHook in Mesos.
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
>   src/slave/containerizer/mesos/launcher.cpp 
> 73a0e5f50042b1249224a4a42e2442b7ea51dfff 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 1c49f568b12f5ad688bb43625de3dcbfd618ca79 
>   src/tests/containerizer/launcher.hpp 
> f87b3ce92c6a5d996995833d79c976db6afe2700 
> 
> Diff: https://reviews.apache.org/r/52018/diff/
> 
> 
> Testing
> ---
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 52018: Renamed Hook to ParentHook in Mesos.

2016-09-18 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52018/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Renamed Hook to ParentHook in Mesos.


Diffs
-

  src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
  src/slave/container_loggers/lib_logrotate.cpp 
1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
  src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
  src/slave/containerizer/mesos/launcher.hpp 
61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
  src/slave/containerizer/mesos/launcher.cpp 
73a0e5f50042b1249224a4a42e2442b7ea51dfff 
  src/slave/containerizer/mesos/linux_launcher.hpp 
dca827cba4d1ead90dba036c9b94ba5e3a3f82fe 
  src/slave/containerizer/mesos/linux_launcher.cpp 
1c49f568b12f5ad688bb43625de3dcbfd618ca79 
  src/tests/containerizer/launcher.hpp f87b3ce92c6a5d996995833d79c976db6afe2700 

Diff: https://reviews.apache.org/r/52018/diff/


Testing
---

sudo make check + internal ci


Thanks,

Joerg Schad