Re: Review Request 52090: Fixed compile error in ppc64le.

2016-09-21 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/#review149848
---


Ship it!




Ship It!

- Jie Yu


On Sept. 21, 2016, 4:44 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52090/
> ---
> 
> (Updated Sept. 21, 2016, 4:44 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6217
> https://issues.apache.org/jira/browse/MESOS-6217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `PAGE_SIZE` is not declared in ppc64le, use `os::pagesize()` instead
> to support different platforms.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
> bab10ae5d488585603db2637ae15ee02b1982354 
> 
> Diff: https://reviews.apache.org/r/52090/diff/
> 
> 
> Testing
> ---
> 
> Fix the error saw in 
> https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52090: Fixed compile error in ppc64le.

2016-09-21 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/
---

(Updated Sept. 21, 2016, 4:44 p.m.)


Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-6217
https://issues.apache.org/jira/browse/MESOS-6217


Repository: mesos


Description (updated)
---

`PAGE_SIZE` is not declared in ppc64le, use `os::pagesize()` instead
to support different platforms.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
bab10ae5d488585603db2637ae15ee02b1982354 

Diff: https://reviews.apache.org/r/52090/diff/


Testing
---

Fix the error saw in 
https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console


Thanks,

haosdent huang

Re: Review Request 52090: Fixed compile error in ppc64le.

2016-09-21 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/
---

(Updated Sept. 21, 2016, 4:42 p.m.)


Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
---

Address @jie's comment.


Bugs: MESOS-6217
https://issues.apache.org/jira/browse/MESOS-6217


Repository: mesos


Description
---

Fixed compile error in ppc64le.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
a1c87ce2ace33f1a779e843578f55d7502562c8d 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
bab10ae5d488585603db2637ae15ee02b1982354 

Diff: https://reviews.apache.org/r/52090/diff/


Testing
---

Fix the error saw in 
https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console


Thanks,

haosdent huang

Re: Review Request 52090: Fixed compile error in ppc64le.

2016-09-21 Thread haosdent huang 


> On Sept. 20, 2016, 9:30 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, 
> > lines 110-115
> > 
> >
> > you can use os::pagesize() here

Orz, thank you very much! Didn't realize we have this util function before.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/#review149733
---


On Sept. 20, 2016, 7:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52090/
> ---
> 
> (Updated Sept. 20, 2016, 7:20 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed compile error in ppc64le.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
> a1c87ce2ace33f1a779e843578f55d7502562c8d 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
> bab10ae5d488585603db2637ae15ee02b1982354 
> 
> Diff: https://reviews.apache.org/r/52090/diff/
> 
> 
> Testing
> ---
> 
> Fix the error saw in 
> https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52090: Fixed compile error in ppc64le.

2016-09-20 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/#review149733
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp (lines 
109 - 114)


you can use os::pagesize() here


- Jie Yu


On Sept. 20, 2016, 7:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52090/
> ---
> 
> (Updated Sept. 20, 2016, 7:20 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed compile error in ppc64le.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
> a1c87ce2ace33f1a779e843578f55d7502562c8d 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
> bab10ae5d488585603db2637ae15ee02b1982354 
> 
> Diff: https://reviews.apache.org/r/52090/diff/
> 
> 
> Testing
> ---
> 
> Fix the error saw in 
> https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 52090: Fixed compile error in ppc64le.

2016-09-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52090/
---

Review request for mesos, Zhiwei Chen, Gilbert Song, Jie Yu, and Qian Zhang.


Repository: mesos


Description
---

Fixed compile error in ppc64le.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 
a1c87ce2ace33f1a779e843578f55d7502562c8d 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 
bab10ae5d488585603db2637ae15ee02b1982354 

Diff: https://reviews.apache.org/r/52090/diff/


Testing
---

Fix the error saw in 
https://builds.apache.org/job/Mesos-PPC64LE/154/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,label_exp=ppc64le/console


Thanks,

haosdent huang