Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150771 --- Fix it, then Ship it! I can tweak these before committing. 3r

Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-26 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/ --- (Updated Sept. 26, 2016, 9:15 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-26 Thread Daniel Pravat
> On Sept. 26, 2016, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/read.hpp, line 35 > > > > > > You wrapped the `::recv` in an earlier patch. Want to use it here? > > (`net::recv`) Good

Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-26 Thread Daniel Pravat
> On Sept. 26, 2016, 8:38 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/sendfile.hpp, line 31 > > > > > > What's this used for? Is MSVC warning because of the bit shifting > > (`offset >> 32`) b

Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150447 --- 3rdparty/stout/include/stout/os/windows/read.hpp (line 35)

Re: Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150439 --- 3rdparty/stout/include/stout/os/windows/read.hpp (line 32)

Review Request 52196: Fixed warnings in `read/write` functions.

2016-09-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos Descr