Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153257
---




docs/linux_capabilities.md (lines 51 - 52)


What's that?


- Alexander Rukletsov


On Oct. 18, 2016, 7:51 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 18, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Avinash sridharan]

> On Oct. 18, 2016, 4:55 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1003
> > 
> >
> > s/the agent/that the agent/
> 
> Benjamin Bannier wrote:
> Not a native speaker but to me this seems to just make the sentence more 
> wordy (and one should probably use `which` instead of `that`). Maybe a native 
> speaker could chime in how this should be phrased.

Valid point. Maybe @Neil or @BenM can chime in?


> On Oct. 18, 2016, 4:55 a.m., Avinash sridharan wrote:
> > docs/linux_capabilities.md, line 3
> > 
> >
> > s/described/describes
> > 
> > to add support for `Linux Capabilities`
> 
> Benjamin Bannier wrote:
> I do not understand your second request. How should the sentence read 
> after applying you suggestion?

I was suggesting:

This document describes the `linux/capabilities` isolator. The isolator adds 
support for controlling `Linux Capabilities` of containers launched using the 
`MesosContainerizer`.

(Re-worded my suggestion a bit actually).


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153028
---


On Oct. 18, 2016, 7:51 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 18, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Benjamin Bannier]

> On Oct. 18, 2016, 6:55 a.m., Avinash sridharan wrote:
> > docs/linux_capabilities.md, line 3
> > 
> >
> > s/described/describes
> > 
> > to add support for `Linux Capabilities`

I do not understand your second request. How should the sentence read after 
applying you suggestion?


> On Oct. 18, 2016, 6:55 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1003
> > 
> >
> > s/the agent/that the agent/

Not a native speaker but to me this seems to just make the sentence more wordy 
(and one should probably use `which` instead of `that`). Maybe a native speaker 
could chime in how this should be phrased.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153028
---


On Oct. 18, 2016, 9:51 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 18, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/
---

(Updated Oct. 18, 2016, 9:51 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-6376
https://issues.apache.org/jira/browse/MESOS-6376


Repository: mesos


Description
---

Added documentation for mesos-containerizer Linux capabilities support.


Diffs (updated)
-

  docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
  docs/linux_capabilities.md PRE-CREATION 
  docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 

Diff: https://reviews.apache.org/r/52783/diff/


Testing
---

Checked with local renderer.


Thanks,

Benjamin Bannier

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review153028
---




docs/configuration.md (line 1003)


s/the agent/that the agent/



docs/configuration.md (line 1005)


is enabled, (linux/capabilities is not present in the
arguments to --isolation) and this flags is ignored.



docs/linux_capabilities.md (line 3)


s/described/describes

to add support for `Linux Capabilities`



docs/linux_capabilities.md (line 9)


s/tasks/Mesos tasks



docs/linux_capabilities.md (line 15)


two lines?



docs/linux_capabilities.md (line 22)


s/capabilities/capability?



docs/linux_capabilities.md (line 34)


s/-allowed_capabilities/--allowed_capabilities

Might be worthwhile to elaborate as to why an agent should ever be started 
with an empty `--allowed_capabilities` flag?


- Avinash sridharan


On Oct. 17, 2016, 1:16 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 17, 2016, 1:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review152971
---


Fix it, then Ship it!




Thanks!!!


docs/linux_capabilities.md (line 11)


s/had/hand/?



docs/linux_capabilities.md (line 44)


I'd also discuss the case where the task specifies some capabilities that 
are not in 'allowed_capabilities', what will happen.


- Jie Yu


On Oct. 17, 2016, 1:16 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 17, 2016, 1:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
>   docs/linux_capabilities.md PRE-CREATION 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/
---

(Updated Oct. 17, 2016, 3:16 p.m.)


Review request for mesos and Jie Yu.


Changes
---

* moved to an extra md file & expanded
* documented new agent flag


Bugs: MESOS-6376
https://issues.apache.org/jira/browse/MESOS-6376


Repository: mesos


Description
---

Added documentation for mesos-containerizer Linux capabilities support.


Diffs (updated)
-

  docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc 
  docs/linux_capabilities.md PRE-CREATION 
  docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 

Diff: https://reviews.apache.org/r/52783/diff/


Testing
---

Checked with local renderer.


Thanks,

Benjamin Bannier

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/#review152768
---



I would like to have another separate docs/linux_capabilities.md to talk about 
how to use the framework API, and what will be the expected behaviors. Also, we 
need some example in the doc.

- Jie Yu


On Oct. 13, 2016, 12:22 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52783/
> ---
> 
> (Updated Oct. 13, 2016, 12:22 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6376
> https://issues.apache.org/jira/browse/MESOS-6376
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for mesos-containerizer Linux capabilities support.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 
> 
> Diff: https://reviews.apache.org/r/52783/diff/
> 
> 
> Testing
> ---
> 
> Checked with local renderer.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/
---

(Updated Oct. 13, 2016, 2:22 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Updated.


Bugs: MESOS-6376
https://issues.apache.org/jira/browse/MESOS-6376


Repository: mesos


Description
---

Added documentation for mesos-containerizer Linux capabilities support.


Diffs (updated)
-

  docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 

Diff: https://reviews.apache.org/r/52783/diff/


Testing
---

Checked with local renderer.


Thanks,

Benjamin Bannier

Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52783/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-6376
https://issues.apache.org/jira/browse/MESOS-6376


Repository: mesos


Description
---

Added documentation for mesos-containerizer Linux capabilities support.


Diffs
-

  docs/mesos-containerizer.md 76544625838845fe2817347fea483a60ab250f99 

Diff: https://reviews.apache.org/r/52783/diff/


Testing
---

Checked with local renderer.


Thanks,

Benjamin Bannier