Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 5, 2016, 7:09 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 7:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157925 --- Fix it, then Ship it! I would file a follow up issue to add

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 6:55 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 916 > > > > > > hmm, this message is a bit mis-leading given that you only start > > processing the

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157914 --- Just a few more minor things to clean up.

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:54 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 916 > > > > > > hmm, this message is a bit mis-leading given that you only start > > processing the

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 3, 2016, 11:45 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 885 > > > > > > Can you add a comment here for posterity as to why these are not > > invariant checks

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157901 --- Modulo Jie's comments. Did an initial pass. Looks pretty good!

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157891 --- Patch looks great! Reviews applied: [54274, 54296, 54297]

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 3, 2016, 2:07 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157789 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 947 -

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157775 --- Let me commit the attach output review/`serv()` to use the

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157762 --- Patch looks great! Reviews applied: [54274, 54296, 54297]

Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-6467