Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

2017-08-11 Thread Benjamin Bannier
> On Aug. 11, 2017, 11:02 a.m., Benjamin Bannier wrote: > > support/apply-reviews.py > > Line 364 (original), 371-373 (patched) > > > > > > Since this prevents running any (pre-)commit hooks, I wonder if we > > shou

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

2017-08-11 Thread Chun-Hung Hsiao
> On Aug. 11, 2017, 9:02 a.m., Benjamin Bannier wrote: > > support/apply-reviews.py > > Line 364 (original), 371-373 (patched) > > > > > > Since this prevents running any (pre-)commit hooks, I wonder if we > > shoul

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

2017-08-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182679 --- Patch looks great! Reviews applied: [61588] Logs available here:

Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.

2017-08-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182670 --- support/apply-reviews.py Lines 263-266 (original), 269-273 (patch

Review Request 61588: Added a `--skip-style-check` option when applying reviews.

2017-08-10 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues. Bugs: MESO