Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.

2017-12-21 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/#review194404
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['64798', '64793', '64794']`

Failed command: 
`D:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64794

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64794/logs/libprocess-tests-stdout.log):

```
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
D:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(446): error: 
(await_subprocess(client.get(), 0)).failure(): 
[++] Subprocess output.
[==] Running 1 test from 1 test case.

[--] Global test environment set-up.

[--] 1 test from SSLClientTest

[ RUN  ] SSLClientTest.client

[   OK ] SSLClientTest.client (20 ms)

[--] 1 test from SSLClientTest (20 ms total)



[--] Global test environment tear-down

[==] 1 test from 1 test case ran. (20 ms total)

[  PASSED  ] 1 test.

[++]

[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = 
"false" (1028 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (959 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (2727 ms total)

[--] Global test environment tear-down
[==] 223 tests from 35 test cases ran. (35821 ms total)
[  PASSED  ] 222 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = 
"false"

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64794/logs/libprocess-tests-stderr.log):

```
LIBPROCESS_SSL_VERIFY_CERT set to true
I1222 05:32:39.823956  6652 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\SeGh36\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1222 05:32:40.865159  9968 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1222 05:32:40.866159  9968 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1222 05:32:40.866159  9968 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1222 05:32:40.866159  9968 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1222 05:32:40.867161  9968 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\7NlRel\cert.pem
bject alternative name certificate extension.
I1222 05:32:38.952924   472 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1222 05:32:38.953924   472 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\BJGZv9\cert.pem
I1222 05:32:38.953924   472 openssl.cpp:566] Using CA dir: 
C:\Users\mesos\AppData\Local\Temp\BJGZv9
I1222 05:32:39.245934   472 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1222 05:32:39.245934   472 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1222 05:32:39.245934   472 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1222 05:32:39.245934   472 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\SeGh36\cert.pem
I1222 05:32:40.287140   472 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1222 05:32:40.287140   472 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1222 05:32:40.288141   472 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1222 05:32:40.288141   472 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1222 05:32:40.288141   472 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\7NlRel\cert.pem
I1222 05:32:40.978648  4808 process.cpp:887] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Dec. 22, 2017, 12:48 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64794/
> ---
> 
> (Updated Dec. 22,

Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.

2017-12-21 Thread Meng Zhu 


> On Dec. 21, 2017, 6:52 p.m., Benjamin Mahler wrote:
> > Nice test! Just some minor suggestions below and what looks like an 
> > inaccurate comment?

Thanks! Comments fixed.


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/#review194395
---


On Dec. 21, 2017, 4:48 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64794/
> ---
> 
> (Updated Dec. 21, 2017, 4:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8352
> https://issues.apache.org/jira/browse/MESOS-8352
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies the behavior of allocating resource to quota roles
> that has no quota set for that particular resource (e.g. allocating
> memory to a role with only quota set for CPU). If a role has no quota
> set for a resource, it will get that resource only when two conditions
> are both met:
> 
> - It got some other resources on the same agent to meet its quota;
> 
> - After allocating the resource, there is still enough resource
> available to meet all other role's quota guarantee for that resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> ad9d556f040b2b51b6c43757f8bad05d61a057e7 
> 
> 
> Diff: https://reviews.apache.org/r/64794/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.

2017-12-21 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/#review194395
---


Fix it, then Ship it!




Nice test! Just some minor suggestions below and what looks like an inaccurate 
comment?


src/tests/hierarchical_allocator_tests.cpp
Lines 3495 (patched)


a resource?



src/tests/hierarchical_allocator_tests.cpp
Lines 3501 (patched)


Maybe: It was allocated quota resources on the agent



src/tests/hierarchical_allocator_tests.cpp
Lines 3503-3504 (patched)


Maybe: It can be allocated without violating the quota headroom



src/tests/hierarchical_allocator_tests.cpp
Lines 3505 (patched)


QuotaRoleAllocateNonQuotaResource?



src/tests/hierarchical_allocator_tests.cpp
Lines 3581 (patched)


Shouldn't memory be absent here?


- Benjamin Mahler


On Dec. 22, 2017, 12:48 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64794/
> ---
> 
> (Updated Dec. 22, 2017, 12:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8352
> https://issues.apache.org/jira/browse/MESOS-8352
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies the behavior of allocating resource to quota roles
> that has no quota set for that particular resource (e.g. allocating
> memory to a role with only quota set for CPU). If a role has no quota
> set for a resource, it will get that resource only when two conditions
> are both met:
> 
> - It got some other resources on the same agent to meet its quota;
> 
> - After allocating the resource, there is still enough resource
> available to meet all other role's quota guarantee for that resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> ad9d556f040b2b51b6c43757f8bad05d61a057e7 
> 
> 
> Diff: https://reviews.apache.org/r/64794/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.

2017-12-21 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/#review194392
---



PASS: Mesos patch 64794 was successfully built and tested.

Reviews applied: `['64793', '64794']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64794

- Mesos Reviewbot Windows


On Dec. 22, 2017, 12:48 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64794/
> ---
> 
> (Updated Dec. 22, 2017, 12:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8352
> https://issues.apache.org/jira/browse/MESOS-8352
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies the behavior of allocating resource to quota roles
> that has no quota set for that particular resource (e.g. allocating
> memory to a role with only quota set for CPU). If a role has no quota
> set for a resource, it will get that resource only when two conditions
> are both met:
> 
> - It got some other resources on the same agent to meet its quota;
> 
> - After allocating the resource, there is still enough resource
> available to meet all other role's quota guarantee for that resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> ad9d556f040b2b51b6c43757f8bad05d61a057e7 
> 
> 
> Diff: https://reviews.apache.org/r/64794/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.

2017-12-21 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8352
https://issues.apache.org/jira/browse/MESOS-8352


Repository: mesos


Description
---

This test verifies the behavior of allocating resource to quota roles
that has no quota set for that particular resource (e.g. allocating
memory to a role with only quota set for CPU). If a role has no quota
set for a resource, it will get that resource only when two conditions
are both met:

- It got some other resources on the same agent to meet its quota;

- After allocating the resource, there is still enough resource
available to meet all other role's quota guarantee for that resource.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
ad9d556f040b2b51b6c43757f8bad05d61a057e7 


Diff: https://reviews.apache.org/r/64794/diff/1/


Testing
---

make check


Thanks,

Meng Zhu