Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review200790
---



PASS: Mesos patch 65940 was successfully built and tested.

Reviews applied: `['65939', '65940']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65940

- Mesos Reviewbot Windows


On April 5, 2018, 4:15 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65940/
> ---
> 
> (Updated April 5, 2018, 4:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test validating hierarchical role accounting.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
>   src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 
> 
> 
> Diff: https://reviews.apache.org/r/65940/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-09 Thread Till Toenshoff 


> On April 6, 2018, 12:25 a.m., Kapil Arya wrote:
> > This looks good to me. I am wondering if we need more test coverage for 
> > insertion/deletion of roles implicit roles. Perhaps a TODO?

Yes, I was considering adding unit-tests for the `RoleTrackingTree` itself, 
that way we can avoid the huge boilerplate needed for running with multiple 
frameworks (e.g. using nested roles) concurrently.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review200609
---


On April 5, 2018, 4:15 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65940/
> ---
> 
> (Updated April 5, 2018, 4:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test validating hierarchical role accounting.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
>   src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 
> 
> 
> Diff: https://reviews.apache.org/r/65940/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review200609
---


Ship it!




This looks good to me. I am wondering if we need more test coverage for 
insertion/deletion of roles implicit roles. Perhaps a TODO?


src/tests/api_tests.cpp
Lines 1072 (patched)


For completeness, can we check `roles(0)` as well?


- Kapil Arya


On April 5, 2018, 12:15 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65940/
> ---
> 
> (Updated April 5, 2018, 12:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test validating hierarchical role accounting.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
>   src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 
> 
> 
> Diff: https://reviews.apache.org/r/65940/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review200557
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65939', '65940']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65940

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65940/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (122 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1097 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (806 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (832 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (830 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (856 ms total)

[--] Global test environment tear-down
[==] 952 tests from 94 test cases ran. (450674 ms total)
[  PASSED  ] 951 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65940/logs/mesos-tests-stderr.log):

```
I0405 17:16:48.497124 16908 slave.cpp:3877] Shutting down framework 
162365de-1c49-4761-b1e9-1f6c7I0405 17:16:48.303117 12204 exec.cpp:162] Version: 
1.6.0
I0405 17:16:48.328111 17380 exec.cpp:236] Executor registered on agent 
162365de-1c49-4761-b1e9-1f6c706fc1ab-S0
I0405 17:16:48.332118  3252 executor.cpp:176] Received SUBSCRIBED event
I0405 17:16:48.337119  3252 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0405 17:16:48.338119  3252 executor.cpp:176] Received LAUNCH event
I0405 17:16:48.347120  3252 executor.cpp:648] Starting task 
c3ca2630-98c5-4529-a2f3-a882b7fc13a3
I0405 17:16:48.438122  3252 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0405 17:16:48.469312  3252 executor.cpp:661] Forked command at 16076
I0405 17:16:48.500109  6336 exec.cpp:445] Executor asked to shutdown
I0405 17:16:48.500109  7048 executor.cpp:176] Received SHUTDOWN event
I0405 17:16:48.500109  7048 executor.cpp:758] Shutting down
I0405 17:16:48.500109  7048 executor.cpp:868] Sending SIGTERM to process tree 
at pid 06fc1ab-
I0405 17:16:48.497124 11856 master.cpp:10617] Updating the state of task 
c3ca2630-98c5-4529-a2f3-a882b7fc13a3 of framework 
162365de-1c49-4761-b1e9-1f6c706fc1ab- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0405 17:16:48.498112 16908 slave.cpp:6574] Shutting down executor 
'c3ca2630-98c5-4529-a2f3-a882b7fc13a3' of framework 
162365de-1c49-4761-b1e9-1f6c706fc1ab- at executor(1)@10.3.1.8:61555
I0405 17:16:48.499109 16900 slave.cpp:923] Agent terminating
W0405 17:16:48.499109 16900 slave.cpp:3873] Ignoring shutdown framework 
162365de-1c49-4761-b1e9-1f6c706fc1ab- because it is terminating
I0405 17:16:48.502121 11856 master.cpp:10716] Removing task 
c3ca2630-98c5-4529-a2f3-a882b7fc13a3 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 162365de-1c49-4761-b1e9-1f6c706fc1ab- on 
agent 162365de-1c49-4761-b1e9-1f6c706fc1ab-S0 at slave(421)@10.3.1.8:61534 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0405 17:16:48.502121  6892 containerizer.cpp:2338] Destroying container 
6b754c01-482d-4a91-b7aa-e58e559ac9cd in RUNNING state
I0405 17:16:48.503108  6892 containerizer.cpp:2952] Transitioning the state of 
container 6b754c01-482d-4a91-b7aa-e58e559ac9cd from RUNNING to DESTROYING
I0405 17:16:48.504112  6892 launcher.cpp:156] Asked to destroy container 
6b754c01-482d-4a91-b7aa-e58e559ac9cd
I0405 17:16:48.506127 11856 master.cpp:1463] Agent 
162365de-1c49-4761-b1e9-1f6c706fc1ab-S0 at slave(421)@10.3.1.8:61534 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0405 17:16:48.506127 11856 master.cpp:3454] Disconnecting ag

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/
---

(Updated April 5, 2018, 4:15 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
Michael Park.


Changes
---

Added unversioned API `/roles`-endpoint test.


Bugs: MESOS-8069
https://issues.apache.org/jira/browse/MESOS-8069


Repository: mesos


Description (updated)
---

Added test validating hierarchical role accounting.


Diffs (updated)
-

  src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
  src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 


Diff: https://reviews.apache.org/r/65940/diff/2/

Changes: https://reviews.apache.org/r/65940/diff/1-2/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review198774
---



Patch looks great!

Reviews applied: [65939, 65940]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 7, 2018, 12:23 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65940/
> ---
> 
> (Updated March 7, 2018, 12:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c6383c455ffc56fa2f0ea97b95e7e0b1a3dd2ec1 
> 
> 
> Diff: https://reviews.apache.org/r/65940/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/#review198757
---



PASS: Mesos patch 65940 was successfully built and tested.

Reviews applied: `['65939', '65940']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65940

- Mesos Reviewbot Windows


On March 7, 2018, 12:23 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65940/
> ---
> 
> (Updated March 7, 2018, 12:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8069
> https://issues.apache.org/jira/browse/MESOS-8069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp c6383c455ffc56fa2f0ea97b95e7e0b1a3dd2ec1 
> 
> 
> Diff: https://reviews.apache.org/r/65940/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65940/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and 
Michael Park.


Bugs: MESOS-8069
https://issues.apache.org/jira/browse/MESOS-8069


Repository: mesos


Description
---

see summary.


Diffs
-

  src/tests/api_tests.cpp c6383c455ffc56fa2f0ea97b95e7e0b1a3dd2ec1 


Diff: https://reviews.apache.org/r/65940/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff