Re: Review Request 66045: Renamed `resources` in allocator to `toAllocate`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66045/#review199211 --- Ship it! - Benjamin Mahler On March 13, 2018, 10:18 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66045/ > --- > > (Updated March 13, 2018, 10:18 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > `resources` is currently used in the allocator to denote > resources that are going to be allocated. This name is too > general and ambiguous. Renamed it to `toAllocate` for > better readability. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 0e8c2c4a52969448f99bd5f42252a84cc52b9271 > > > Diff: https://reviews.apache.org/r/66045/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 66045: Renamed `resources` in allocator to `toAllocate`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66045/#review199137 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66043', '66044', '66045']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66045 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66045/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (124 ms) [--] 9 tests from Endpoint/SlaveEndpointTest (1224 ms total) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (44 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (84 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2521 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (2544 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2589 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (2613 ms total) [--] Global test environment tear-down [==] 916 tests from 91 test cases ran. (478830 ms total) [ PASSED ] 915 tests. [ FAILED ] 1 test, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout 1 FAILED TEST YOU HAVE 210 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66045/logs/mesos-tests-stderr.log): ``` I0314 01:21:22.078588 7796 master.cpp:10245] Updating the state of task f5a632e5-5f48-4797-8945-1d650bed106c of framework 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532- (latest state: TASK_KILLED, status update state: TASK_KILLED) I0314 01:21:22.078588 8552 slave.cpp:3878] Shutting down framework 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532- I0314 01:21:22.078588 8552 slave.cpp:6571] Shutting down executor 'f5a632e5-5f48-4797-8945-1d650bed106c' of framework 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532- at executor(1)@10.3.1.11:60818 I0314 01:21:22.079625 8552 slave.cpp:924] Agent terminating W0314 01:21:22.080740 8552 slave.cpp:3874] Ignoring shutdown framework 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532- because it iI0314 01:21:21.354588 10480 exec.cpp:162] Version: 1.6.0 I0314 01:21:21.384590 7648 exec.cpp:236] Executor registered on agent 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532-S0 I0314 01:21:21.389588 7492 executor.cpp:176] Received SUBSCRIBED event I0314 01:21:21.394593 7492 executor.cpp:180] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0314 01:21:21.394593 7492 executor.cpp:176] Received LAUNCH event I0314 01:21:21.399595 7492 executor.cpp:648] Starting task f5a632e5-5f48-4797-8945-1d650bed106c I0314 01:21:21.483616 7492 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0314 01:21:22.035612 7492 executor.cpp:661] Forked command at 9412 I0314 01:21:22.081590 10756 exec.cpp:445] Executor asked to shutdown I0314 01:21:22.083591 7492 executor.cpp:176] Received SHUTDOWN event I0314 01:21:22.083591 7492 executor.cpp:758] Shutting down I0314 01:21:22.084589 7492 executor.cpp:868] Sending SIGTERM to process tree at pid 9s terminating I0314 01:21:22.081590 7796 master.cpp:10344] Removing task f5a632e5-5f48-4797-8945-1d650bed106c with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532- on agent 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532-S0 at slave(398)@10.3.1.11:60797 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0314 01:21:22.084589 7796 master.cpp:1288] Agent 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532-S0 at slave(398)@10.3.1.11:60797 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected I0314 01:21:22.084589 7796 master.cpp:3258] Disconnecting agent 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532-S0 at slave(398)@10.3.1.11:60797 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0314 01:21:22.084589 7796 master.cpp:3277] Deactivating agent 1ad1cc77-e2d2-4f8d-aef1-fee24dce5532-S0 at slave(398)@10.3.1.11:60797 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0314 01:21:22.084589 11124 hie
Review Request 66045: Renamed `resources` in allocator to `toAllocate`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66045/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- `resources` is currently used in the allocator to denote resources that are going to be allocated. This name is too general and ambiguous. Renamed it to `toAllocate` for better readability. Diffs - src/master/allocator/mesos/hierarchical.cpp 0e8c2c4a52969448f99bd5f42252a84cc52b9271 Diff: https://reviews.apache.org/r/66045/diff/1/ Testing --- make check Thanks, Meng Zhu
