Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-20 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/
---

(Updated April 20, 2018, 5:03 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Rebased + updates due to having changed the signature of the Scheduler library 
`call()` method.


Bugs: MESOS-8191
https://issues.apache.org/jira/browse/MESOS-8191


Repository: mesos


Description
---

Added tests for operation status reconciliation.


Diffs (updated)
-

  src/Makefile.am 9d610bbe8108e5caa4a22977caa9dff07c8bb665 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/mesos.hpp 7356523a2a37858bbe866527425f35502ff5ad82 
  src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/66468/diff/5/

Changes: https://reviews.apache.org/r/66468/diff/4-5/


Testing
---

The new tests passed 1000 iterations on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-11 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200918
---


Ship it!




Ship It!

- Greg Mann


On April 10, 2018, 9:56 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 9:56 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/4/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200865
---



Patch looks great!

Reviews applied: [66458, 66459, 66460, 66461, 66489, 66462, 66463, 66464, 
66465, 66466, 66467, 66468]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 10, 2018, 9:56 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 9:56 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/4/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200857
---



PASS: Mesos patch 66468 was successfully built and tested.

Reviews applied: `['66458', '66459', '66460', '66461', '66489', '66462', 
'66463', '66464', '66465', '66466', '66467', '66468']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468

- Mesos Reviewbot Windows


On April 10, 2018, 9:56 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 9:56 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/4/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/
---

(Updated April 10, 2018, 2:56 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Disabled on Windows a test that requires the replicated log, which isn't 
supported on Windwos.


Repository: mesos


Description
---

Added tests for operation status reconciliation.


Diffs (updated)
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/66468/diff/4/

Changes: https://reviews.apache.org/r/66468/diff/3-4/


Testing
---

The new tests passed 1000 iterations on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200845
---



Patch looks great!

Reviews applied: [66458, 66459, 66460, 66461, 66489, 66462, 66463, 66464, 
66465, 66466, 66467, 66468]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 10, 2018, 11:45 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 11:45 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/3/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200839
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66458', '66459', '66460', '66461', '66489', '66462', 
'66463', '66464', '66465', '66466', '66467', '66468']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (1104 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (796 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (824 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (813 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (839 ms total)

[--] Global test environment tear-down
[==] 968 tests from 95 test cases ran. (439901 ms total)
[  PASSED  ] 966 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/0, where 
GetParam() = application/x-protobuf
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/1, where 
GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stderr.log):

```
II0410 19:45:45.065649 22136 exec.cpp:162] Version: 1.6.0
I0410 19:45:45.093673 23124 exec.cpp:236] Executor registered on agent 
e2a54159-1b89-4598-80c7-6aad0a63e716-S0
I0410 19:45:45.097678 21904 executor.cpp:177] Received SUBSCRIBED event
I0410 19:45:45.102671 21904 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0410 19:45:45.102671 21904 executor.cpp:177] Received LAUNCH event
I0410 19:45:45.107671 21904 executor.cpp:649] Starting task 
f428fa3b-5afa-4aa6-8d12-f35afe8f3578
I0410 19:45:45.197675 21904 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0410 19:45:45.230665 21904 executor.cpp:662] Forked command at 18632
I0410 19:45:45.266690 10936 exec.cpp:445] Executor asked to shutdown
I0410 19:45:45.267647 22416 executor.cpp:177] Received SHUTDOWN event
I0410 19:45:45.267647 22416 executor.cpp:759] Shutting down
I0410 19:45:45.267647 22416 executor.cpp:869] Sending SIGTERM to process tree 
at pid 0410 19:45:45.263679 19476 master.cpp:10567] Updating the state of task 
f428fa3b-5afa-4aa6-8d12-f35afe8f3578 of framework 
e2a54159-1b89-4598-80c7-6aad0a63e716- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0410 19:45:45.263679 22892 slave.cpp:3973] Shutting down framework 
e2a54159-1b89-4598-80c7-6aad0a63e716-
I0410 19:45:45.264657 22892 slave.cpp:6670] Shutting down executor 
'f428fa3b-5afa-4aa6-8d12-f35afe8f3578' of framework 
e2a54159-1b89-4598-80c7-6aad0a63e716- at executor(1)@10.3.1.8:58481
I0410 19:45:45.266690 11396 slave.cpp:923] Agent terminating
W0410 19:45:45.266690 11396 slave.cpp:3969] Ignoring shutdown framework 
e2a54159-1b89-4598-80c7-6aad0a63e716- because it is terminating
I0410 19:45:45.268725 19476 master.cpp:10666] Removing task 
f428fa3b-5afa-4aa6-8d12-f35afe8f3578 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework e2a54159-1b89-4598-80c7-6aad0a63e716- on 
agent e2a54159-1b89-4598-80c7-6aad0a63e716-S0 at slave(433)@10.3.1.8:58460 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0410 19:45:45.270648 14944 containerizer.cpp:2338] Destroying container 
ccb6f3b3-c36b-4aa1-b463-d1d15b3ad8c1 in RUNNING state
I0410 19:45:45.270648 14944 containerizer.cpp:2952] Transitioning the state of 
container ccb6f3b3-c36b-4aa1-b463-d1d15b3ad8c1 from RUNNING to DESTROYING
I0410 19:45:45.271651 14944 launcher.cpp:156] Asked to destroy container 
ccb6f3b3-c36b-4aa1-b463-d1d15b3ad8c1
I0410 19:45:45.271651 19476 master.cp

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Gaston Kleiman 


> On April 9, 2018, 5:08 p.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 364-365 (patched)
> > 
> >
> > Is there a reason not to do this with a `for` loop?
> 
> Gaston Kleiman wrote:
> I copied & pasted this from 
> https://github.com/apache/mesos/blob/be47e96e727f07758ff9b8ba1c23bbec2a489cd6/src/tests/reconciliation_tests.cpp#L1221-L1230,
>  so consistency with that file would be the only reason =).
> 
> Doing this with a `for` loop calls `FUTURE_MESSAGE` and `Clock::advance` 
> one extra time, but that doesn't really hurt, so I converted the `while` loop 
> into a `for` loop. Let me know if you like it this way or if you'd prefer me 
> to revert this change.

I changed it back to a `while` loop as discussed in chat.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200769
---


On April 10, 2018, 11:45 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 11:45 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/3/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-10 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/
---

(Updated April 10, 2018, 11:45 a.m.)


Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added tests for operation status reconciliation.


Diffs (updated)
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/66468/diff/3/

Changes: https://reviews.apache.org/r/66468/diff/2-3/


Testing
---

The new tests passed 1000 iterations on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200794
---



Patch looks great!

Reviews applied: [66458, 66459, 66460, 66461, 66489, 66462, 66463, 66464, 
66465, 66466, 66467, 66468]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 10, 2018, 12:30 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 12:30 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/2/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200786
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66458', '66459', '66460', '66461', '66489', '66462', 
'66463', '66464', '66465', '66466', '66467', '66468']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (1069 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (824 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (848 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (838 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (866 ms total)

[--] Global test environment tear-down
[==] 968 tests from 95 test cases ran. (442285 ms total)
[  PASSED  ] 966 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/0, where 
GetParam() = application/x-protobuf
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/1, where 
GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stderr.log):

```
I0410 01:23:52.161422 20352 slave.cpp:3973] Shutting down framework 
a9d6834a-7b1d-4da5-a375-3b7dcce77cc3-
I0410 01:23:52.161422 18052 master.cpp:10567] Updating the state of task 
6fc1f90b-e426-4b3b-b7a2-2d4a9eed5c10 of framework 
a9d6834a-7b1d-4da5-a375-3b7dcce77cc3- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0410 01:23:52.161422 20352 slave.cpp:66I0410 01:23:51.968423 16500 
exec.cpp:162] Version: 1.6.0
I0410 01:23:51.997421 19168 exec.cpp:236] Executor registered on agent 
a9d6834a-7b1d-4da5-a375-3b7dcce77cc3-S0
I0410 01:23:52.001416 20052 executor.cpp:177] Received SUBSCRIBED event
I0410 01:23:52.005412 20052 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0410 01:23:52.008416 17552 executor.cpp:177] Received LAUNCH event
I0410 01:23:52.014408 17552 executor.cpp:649] Starting task 
6fc1f90b-e426-4b3b-b7a2-2d4a9eed5c10
I0410 01:23:52.100420 17552 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0410 01:23:52.130422 17552 executor.cpp:662] Forked command at 11604
I0410 01:23:52.163411  2132 exec.cpp:445] Executor asked to shutdown
I0410 01:23:52.164407 17528 executor.cpp:177] Received SHUTDOWN event
I0410 01:23:52.164407 17528 executor.cpp:759] Shutting down
I0410 01:23:52.164407 17528 executor.cpp:869] Sending SIGTERM to process tree 
at pid 70] Shutting down executor '6fc1f90b-e426-4b3b-b7a2-2d4a9eed5c10' of 
framework a9d6834a-7b1d-4da5-a375-3b7dcce77cc3- at 
executor(1)@10.3.1.8:55152
I0410 01:23:52.163411 20352 slave.cpp:923] Agent terminating
W0410 01:23:52.163411 20352 slave.cpp:3969] Ignoring shutdown framework 
a9d6834a-7b1d-4da5-a375-3b7dcce77cc3- because it is terminating
I0410 01:23:52.164407 18052 master.cpp:10666] Removing task 
6fc1f90b-e426-4b3b-b7a2-2d4a9eed5c10 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework a9d6834a-7b1d-4da5-a375-3b7dcce77cc3- on 
agent a9d6834a-7b1d-4da5-a375-3b7dcce77cc3-S0 at slave(433)@10.3.1.8:55131 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0410 01:23:52.167402 19504 containerizer.cpp:2338] Destroying container 
354c5c1e-c756-424f-8a47-609dc5a8e54d in RUNNING state
I0410 01:23:52.167402 19504 containerizer.cpp:2952] Transitioning the state of 
container 354c5c1e-c756-424f-8a47-609dc5a8e54d from RUNNING to DESTROYING
I0410 01:23:52.167402 18052 master.cpp:1295] Agent 
a9d6834a-7b1d-4da5-a375-3b7dcce77cc3-S0 at slave(433)@10.3.1.8:55131 
(winbldsrv-01.zq4gs31qjdi

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Gaston Kleiman 


> On April 9, 2018, 5:08 p.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 364-365 (patched)
> > 
> >
> > Is there a reason not to do this with a `for` loop?

I copied & pasted this from 
https://github.com/apache/mesos/blob/be47e96e727f07758ff9b8ba1c23bbec2a489cd6/src/tests/reconciliation_tests.cpp#L1221-L1230,
 so consistency with that file would be the only reason =).

Doing this with a `for` loop calls `FUTURE_MESSAGE` and `Clock::advance` one 
extra time, but that doesn't really hurt, so I converted the `while` loop into 
a `for` loop. Let me know if you like it this way or if you'd prefer me to 
revert this change.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200769
---


On April 9, 2018, 5:30 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 9, 2018, 5:30 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/2/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/
---

(Updated April 9, 2018, 5:30 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed Greg's comments.


Repository: mesos


Description
---

Added tests for operation status reconciliation.


Diffs (updated)
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/66468/diff/2/

Changes: https://reviews.apache.org/r/66468/diff/1-2/


Testing
---

The new tests passed 1000 iterations on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200769
---



Nice tests!


src/tests/operation_reconciliation_tests.cpp
Lines 123 (patched)


Not indented far enough.



src/tests/operation_reconciliation_tests.cpp
Lines 364-365 (patched)


Is there a reason not to do this with a `for` loop?



src/tests/operation_reconciliation_tests.cpp
Lines 461 (patched)


Can we eliminate this local variable?



src/tests/operation_reconciliation_tests.cpp
Lines 592 (patched)


As discussed in chat, we can probably remove this test.



src/tests/operation_reconciliation_tests.cpp
Lines 804 (patched)


s/belongs//



src/tests/operation_reconciliation_tests.cpp
Lines 910 (patched)


Not indented far enough.



src/tests/operation_reconciliation_tests.cpp
Lines 990-992 (patched)


Remove this newline.



src/tests/operation_reconciliation_tests.cpp
Lines 1019-1021 (patched)


Remove this newline.


- Greg Mann


On April 9, 2018, 9:53 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 9, 2018, 9:53 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/1/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200779
---



Patch looks great!

Reviews applied: [66458, 66459, 66460, 66461, 66489, 66462, 66463, 66464, 
66465, 66466, 66467, 66468]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2018, 9:53 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 9, 2018, 9:53 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/1/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200776
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66458', '66459', '66460', '66461', '66489', '66462', 
'66463', '66464', '66465', '66466', '66467', '66468']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (1075 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (794 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (820 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (839 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (866 ms total)

[--] Global test environment tear-down
[==] 970 tests from 95 test cases ran. (442741 ms total)
[  PASSED  ] 968 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/0, where 
GetParam() = application/x-protobuf
[  FAILED  ] 
ContentType/OperationReconciliationTest.UnknownOperationRecoveredAgent/1, where 
GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66468/logs/mesos-tests-stderr.log):

```
I0409 22:53:54.540514 13084 master.cpp:10567] Updating the state of task 
12d7222e-17b7-4f6c-b3e8-3d041a5736e6 of framework 
b43029a8-bf67-4974-b76e-b57534b9debd- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0409 22:53:54.540514 18280 slave.cpp:3973] Shutting down framework 
b43029a8-bf67-4974-b76e-b57534b9debd-
I0409 22:53:54.540514 18280 slave.cpp:6670] Shutting down executor 
'12d7222e-17b7-4f6c-b3e8-3d041a5736e6' of framework 
b43029a8-bf67-4974-b76e-b57534b9debd- at executor(1)@10.3.1.8:52653
I0409 22:53:54.541523 18280 slaI0409 22:53:54.303508 16996 exec.cpp:162] 
Version: 1.6.0
I0409 22:53:54.328505 12344 exec.cpp:236] Executor registered on agent 
b43029a8-bf67-4974-b76e-b57534b9debd-S0
I0409 22:53:54.332504 18756 executor.cpp:177] Received SUBSCRIBED event
I0409 22:53:54.339509 18756 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0409 22:53:54.340507 18756 executor.cpp:177] Received LAUNCH event
I0409 22:53:54.346516 18756 executor.cpp:649] Starting task 
12d7222e-17b7-4f6c-b3e8-3d041a5736e6
I0409 22:53:54.473526 18756 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0409 22:53:54.509528 18756 executor.cpp:662] Forked command at 17840
I0409 22:53:54.542521  8524 exec.cpp:445] Executor asked to shutdown
I0409 22:53:54.543520  3916 executor.cpp:177] Received SHUTDOWN event
I0409 22:53:54.543520  3916 executor.cpp:759] Shutting down
I0409 22:53:54.543520  3916 executor.cpp:869] Sending SIGTERM to process tree 
at pid ve.cpp:923] Agent terminating
W0409 22:53:54.542521 18280 slave.cpp:3969] Ignoring shutdown framework 
b43029a8-bf67-4974-b76e-b57534b9debd- because it is terminating
I0409 22:53:54.542521 13084 master.cpp:10666] Removing task 
12d7222e-17b7-4f6c-b3e8-3d041a5736e6 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework b43029a8-bf67-4974-b76e-b57534b9debd- on 
agent b43029a8-bf67-4974-b76e-b57534b9debd-S0 at slave(435)@10.3.1.8:52632 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0409 22:53:54.545518 13084 master.cpp:1295] Agent 
b43029a8-bf67-4974-b76e-b57534b9debd-S0 at slave(435)@10.3.1.8:52632 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0409 22:53:54.545518  9556 containerizer.cpp:2338] Destroying container 
cc397ac0-6831-429b-a581-aafb1ed597b6 in RUNNING state
I0409 22:53:54.545518 13084 master.cpp:3286] Disconnecting agent 
b43029a8-bf67-4974-b76e-b57534b9d

Review Request 66468: Added tests for operation status reconciliation.

2018-04-09 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/
---

Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Added tests for operation status reconciliation.


Diffs
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/66468/diff/1/


Testing
---

The new tests passed 1000 iterations on GNU/Linux.


Thanks,

Gaston Kleiman