Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review205263 --- Patch looks great! Reviews applied: [67384, 67385, 67386, 67387,

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review205262 --- PASS: Mesos patch 67457 was successfully built and tested.

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review205210 --- Patch looks great! Reviews applied: [67384, 67385, 67386, 67387,

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review205174 --- PASS: Mesos patch 67457 was successfully built and tested.

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-12 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204619 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-12 Thread Andrew Schwartzmeyer
> On June 8, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Line 300 (original), 339 (patched) > > > > > > What changed here to need another argument? >

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204507 --- Fix it, then Ship it!

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204351 --- Patch looks great! Reviews applied: [67384, 67385, 67386, 67387,

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204347 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

2018-06-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Bugs: MESOS-7342