[GitHub] spark pull request: [SPARK-3686][STREAMING] Wait for sink to commi...

2014-09-25 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/2531#issuecomment-56777200 Let me see if I can add a method in the sink that can be used to query if the acks have come. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-3632] ConnectionManager can run out of ...

2014-09-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2484#issuecomment-56777341 Hey sorry really busy this week. I will take a look at this next week. Added to my todo list. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56777443 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56777484 LGTM too - this is a good idea! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3686][STREAMING] Wait for sink to commi...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2531#issuecomment-56777581 That would be great. If you _really_ need to rely on sleeps then it would be good to at least sleep in several smaller intervals rather than 1 second and check multiple

[GitHub] spark pull request: [SPARK-2778] [yarn] Add yarn integration tests...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2257#issuecomment-56777632 Thanks Marcelo and @andrewor14 for review - I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56777609 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20782/consoleFull) for PR 2216 at commit

[GitHub] spark pull request: Spark Core - [SPARK-3620] - Refactor of SparkS...

2014-09-25 Thread tigerquoll
Github user tigerquoll commented on the pull request: https://github.com/apache/spark/pull/2516#issuecomment-56777816 vanzin - great feedback. thanks for the effort of going through the code. I've implemented all the requested changes. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-2778] [yarn] Add yarn integration tests...

2014-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2444#discussion_r18016579 --- Diff: sbin/slaves.sh --- @@ -67,23 +69,34 @@ fi if [ $HOSTLIST = ]; then if [ $SPARK_SLAVES = ]; then -export

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2444#issuecomment-56778519 This looks good, just had a minor comment, then I think it's ready to merge. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [Build]remove spark-staging-1030

2014-09-25 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2532 [Build]remove spark-staging-1030 Since 1.1.0 has published, remove spark-staging-1030. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scwf/spark

[GitHub] spark pull request: [Build]remove spark-staging-1030

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2532#issuecomment-56778595 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3686][STREAMING] Wait for sink to commi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2531#issuecomment-56778924 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20780/consoleFull) for PR 2531 at commit

[GitHub] spark pull request: [SPARK-3686][STREAMING] Wait for sink to commi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2531#issuecomment-56778929 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3658][SQL]Take thrift server as a daemo...

2014-09-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2509#issuecomment-56779230 @liancheng - can you take a look at this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3074] [PySpark] support groupByKey() wi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1977#issuecomment-56780803 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20781/consoleFull) for PR 1977 at commit

[GitHub] spark pull request: [SPARK-3074] [PySpark] support groupByKey() wi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1977#issuecomment-56780634 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/151/consoleFull) for PR 1977 at commit

[GitHub] spark pull request: [SPARK-3074] [PySpark] support groupByKey() wi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1977#issuecomment-56780807 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: add a util method for changing the log level w...

2014-09-25 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/2433#issuecomment-56780109 Sure I will do that tomorrow :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56782577 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56782572 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20782/consoleFull) for PR 2216 at commit

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56782760 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20783/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56782832 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56782830 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20783/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: [SPARK-3414][SQL] Replace LowerCaseSchema with...

2014-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/2382#discussion_r18017841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -96,21 +103,69 @@ abstract class LogicalPlan

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56783948 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20785/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56784022 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20785/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56784025 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56784194 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3658][SQL]Take thrift server as a daemo...

2014-09-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2509#discussion_r18018270 --- Diff: sbin/spark-daemon.sh --- @@ -142,8 +142,12 @@ case $startStop in spark_rotate_log $log echo starting $command, logging to

[GitHub] spark pull request: [SPARK-3658][SQL]Take thrift server as a daemo...

2014-09-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2509#discussion_r18018267 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -320,6 +320,10 @@ object SparkSubmit { } catch { case e:

[GitHub] spark pull request: [SPARK-3658][SQL]Take thrift server as a daemo...

2014-09-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2509#discussion_r18018268 --- Diff: sbin/spark-daemon.sh --- @@ -142,8 +142,12 @@ case $startStop in spark_rotate_log $log echo starting $command, logging to

[GitHub] spark pull request: [SPARK-3658][SQL]Take thrift server as a daemo...

2014-09-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2509#issuecomment-56784684 Generally this is a good idea. But it would be better to make `spark-daemon.sh` more general, rather than making `HiveThriftServer2` a special case. --- If your

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2435#issuecomment-56785203 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2435#discussion_r18018595 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/impl/BaggedPoint.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2435#issuecomment-56785807 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20786/consoleFull) for PR 2435 at commit

[GitHub] spark pull request: [SPARK-3476] Remove outdated memory checks in ...

2014-09-25 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2528#issuecomment-56786377 The changes conceptually look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2435#discussion_r18019000 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DecisionTreeMetadata.scala --- @@ -128,13 +139,34 @@ private[tree] object

[GitHub] spark pull request: [SPARK-3614][MLLIB] Add minimumOccurence filte...

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2494#issuecomment-56786758 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3614][MLLIB] Add minimumOccurence filte...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2494#issuecomment-56787034 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20787/consoleFull) for PR 2494 at commit

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2419#issuecomment-56787087 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2419#issuecomment-56787244 @derrickburns Maybe Jenkins didn't clean the working directory. I will test it locally, while asking Jenkins to retry. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-3325] Add a parameter to the method pri...

2014-09-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2216#issuecomment-56787307 MIMA is complaining because a method is added to trait `JavaDStreamLike`. I think it should just be suppressed, as there's no guarantee to callers that this trait won't

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2419#issuecomment-56787448 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20789/consoleFull) for PR 2419 at commit

[GitHub] spark pull request: [SPARK-3032][Shuffle] Fix key comparison integ...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2514#issuecomment-56787444 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20788/consoleFull) for PR 2514 at commit

[GitHub] spark pull request: [SPARK-3250] Implement Gap Sampling optimizati...

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2455#issuecomment-56787973 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MLlib] [SPARK-2885] DIMSUM: All-pairs similar...

2014-09-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1778#issuecomment-56789080 @rezazadeh I made some changes in a local branch:

[GitHub] spark pull request: [SPARK-3250] Implement Gap Sampling optimizati...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2455#issuecomment-56789072 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3032][Shuffle] Fix key comparison integ...

2014-09-25 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/2514#issuecomment-56789130 Hi Matei, I modify the unit test to reproduce the exception. Seems it is difficult to reproduce this exception with small dataset manually, as this exception is

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56789789 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20793/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56790021 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2098] All Spark processes should suppor...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2379#issuecomment-56790524 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56790721 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20795/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56791029 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56791103 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20795/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56791106 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56791243 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20796/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56791275 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20797/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [SPARK-3614][MLLIB] Add minimumOccurence filte...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2494#issuecomment-56791986 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3614][MLLIB] Add minimumOccurence filte...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2494#issuecomment-56791980 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20787/consoleFull) for PR 2494 at commit

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2435#issuecomment-56792111 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20786/consoleFull) for PR 2435 at commit

[GitHub] spark pull request: [SPARK-1545] [mllib] Add Random Forests

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2435#issuecomment-56792119 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3032][Shuffle] Fix key comparison integ...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2514#issuecomment-56792692 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3032][Shuffle] Fix key comparison integ...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2514#issuecomment-56792685 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20788/consoleFull) for PR 2514 at commit

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2419#issuecomment-56792727 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20789/consoleFull) for PR 2419 at commit

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2419#issuecomment-56792730 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56796548 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56796540 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20796/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56796798 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20793/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56796805 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56798291 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20797/consoleFull) for PR 1290 at commit

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-56798296 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread jyotiska
Github user jyotiska commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56800752 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56801157 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20798/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2444#issuecomment-56801729 Thanks @pwendell , I've modified what you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2444#issuecomment-56801957 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20799/consoleFull) for PR 2444 at commit

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread tigerquoll
GitHub user tigerquoll opened a pull request: https://github.com/apache/spark/pull/2533 SPARK-CORE [SPARK-3651] Group common CoarseGrainedSchedulerBackend variables together from [SPARK-3651] In CoarseGrainedSchedulerBackend, we have: private val executorActor =

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2533#issuecomment-56803421 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3677] [BUILD] [YARN] Scalastyle is neve...

2014-09-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2520#issuecomment-56804405 @vanzin Thanks for check this PR out. If we run scalastyle with sbt like sbt -Phadoop-2.3 -Pyarn scalastyle, Maven doesn't execute scalastyle (If we run scalastyle with

[GitHub] spark pull request: [SPARK-3580] add 'partitions' property to PySp...

2014-09-25 Thread mattf
Github user mattf commented on the pull request: https://github.com/apache/spark/pull/2478#issuecomment-56805152 RDD._jrdd is very heavy for PipelinedRDD, but getNumPartitions() could be optimized for PipelinedRDD to avoid the creation of _jrdd (could be

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026314 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -62,15 +62,9 @@ class

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026563 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -85,16 +79,18 @@ class

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026675 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -104,13 +100,15 @@ class

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026654 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -85,16 +79,18 @@ class

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026763 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -126,8 +124,8 @@ class

[GitHub] spark pull request: [SPARK-3377] [SPARK-3610] Metrics can be accid...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2432#issuecomment-56806613 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20800/consoleFull) for PR 2432 at commit

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026850 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -149,13 +147,14 @@ class

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56806975 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20798/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18026933 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -179,25 +178,22 @@ class

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56806982 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18027054 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -179,25 +178,22 @@ class

[GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...

2014-09-25 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/2533#discussion_r18027094 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -179,25 +178,22 @@ class

[GitHub] spark pull request: Python SQL Example Code

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2521#issuecomment-56807555 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20801/consoleFull) for PR 2521 at commit

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2444#issuecomment-56807831 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2444#issuecomment-56807825 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20799/consoleFull) for PR 2444 at commit

[GitHub] spark pull request: [SPARK-3614][MLLIB] Add minimumOccurence filte...

2014-09-25 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2494#issuecomment-56807991 The flume sink test failed -- unrelated to my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3377] [SPARK-3610] Metrics can be accid...

2014-09-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2432#issuecomment-56808038 @JoshRosen Unifying the unique identifier for each application is make sense. I implemented applicationId to return System.currentTimeMillis as a default unique ID,

[GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...

2014-09-25 Thread mattf
Github user mattf commented on a diff in the pull request: https://github.com/apache/spark/pull/2444#discussion_r18027788 --- Diff: docs/spark-standalone.md --- @@ -62,7 +62,12 @@ Finally, the following configuration options can be passed to the master and wor # Cluster

[GitHub] spark pull request: [SPARK-3677] [BUILD] [YARN] Scalastyle is neve...

2014-09-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2520#issuecomment-56809392 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20802/consoleFull) for PR 2520 at commit

  1   2   3   4   5   >